Skip to content

feat(tests): extend EIP-7708, EIP-8024 and EIP-8037 coverage - #3678

Merged
marioevz merged 3 commits into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:multiple-coverage-enhancement
Sep 30, 2026
Merged

marioevz merged 3 commits into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:multiple-coverage-enhancement

Conversation

@LouisTsai-Csie

Copy link
Copy Markdown
Contributor

Description

EIP-7708

  • A value CALL into a precompile logs the transfer only if the precompile succeeds.
  • A delegated EOA that sends value is logged as the sender, not its delegation target.

EIP-8024

  • Jump-to-immediate tests for DUPN, SWAPN and EXCHANGE now also run with a taken JUMPI.

EIP-8037

  • Absent coinbase: value sent to a coinbase that does not exist yet still pays NEW_ACCOUNT, because the priority fee arrives only after execution. Covered by a recipient_is_coinbase case on the tx-value, CALL and SELFDESTRUCT boundary tests.
  • Value CALL: NEW_ACCOUNT is charged before the balance check, so a zero-balance frame one gas short halts.
  • SELFDESTRUCT as coinbase: a creation tx whose created address is the coinbase and whose initcode self-destructs keeps the endowment plus the fee.

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie self-assigned this Sep 30, 2026
@LouisTsai-Csie LouisTsai-Csie added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.62%. Comparing base (3e17067) to head (45d9afe).
⚠️ Report is 7 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3678      +/-   ##
===================================================
+ Coverage            94.54%   94.62%   +0.07%     
===================================================
  Files                  624      624              
  Lines                37021    36976      -45     
  Branches              3349     3349              
===================================================
- Hits                 35003    34988      -15     
+ Misses                1427     1397      -30     
  Partials               591      591              
Flag Coverage Δ
unittests 94.62% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've verified all tests and made some small changes plus a new test in commit 45d9afe. Thanks for this!

@marioevz
marioevz merged commit 3925dfc into ethereum:forks/amsterdam Sep 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants