Skip to content

Add EvcLoader#84

Draft
wrbl606 wants to merge 5 commits into
ethanblake4:masterfrom
wrbl606:evc_loaders
Draft

Add EvcLoader#84
wrbl606 wants to merge 5 commits into
ethanblake4:masterfrom
wrbl606:evc_loaders

Conversation

@wrbl606

@wrbl606 wrbl606 commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Add EvcLoader and its implementations for asset, file, http fetching to:

  • reuse code loading logic between widgets
  • support custom loaders for e.g. fetching files over gRPC, auth-only HTTP endpoints, encrypted files, ...

Docs to be added/updated, just let me know if there's something I've missed in the current implementation first 😇

@wrbl606

wrbl606 commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

@ethanblake4 any objections to the proposal? 😇

@ethanblake4

Copy link
Copy Markdown
Owner

Thanks, that's a great idea. The only potential issue is that it is replacing all synchronous file I/O with async file I/O which is slower, and in the case of HotSwapLoader which actually blocks your whole app from loading until the runtime has been created, this could cause a slower start-up time. The amount of time might be irrelevant, but I'd appreciate if you could test that (a basic test program that just tests sync and async loading speed of a standard EVC file is fine) just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants