Repository navigation
lease: reopen the keepAlive stream when the server ends it - #1628
Open
q-llewellynthomas wants to merge 1 commit into
Open
q-llewellynthomas wants to merge 1 commit into
q-llewellynthomas wants to merge 1 commit into
Conversation
LeaseImpl opened the shared LeaseKeepAlive stream with no end handler, so when the server ended the stream with status OK (e.g. an etcd member shutting down gracefully, or a proxy closing the stream) the stream was dead but the KeepAlive service still considered itself running. Every lease, including ones added later, stopped being renewed and expired at its TTL, and nothing restarted the stream until the client was rebuilt. The stream is now reopened after a clean end, on the same 500ms schedule used after an error. Observers are not notified, since the leases are still valid. keepAliveOnce also completes exceptionally on a clean end with no response, rather than leaving its future incomplete forever. Fixes etcd-io#1383 Signed-off-by: Llewellyn Thomas <llewellynthomas@quantexa.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: q-llewellynthomas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LeaseImpl opened the shared LeaseKeepAlive stream with no end handler, so when the server ended the stream with status OK (e.g. an etcd member shutting down gracefully, or a proxy closing the stream) the stream was dead but the KeepAlive service still considered itself running. Every lease, including ones added later, stopped being renewed and expired at its TTL, and nothing restarted the stream until the client was rebuilt.
The stream is now reopened after a clean end, on the same 500ms schedule used after an error. Observers are not notified, since the leases are still valid. keepAliveOnce also completes exceptionally on a clean end with no response, rather than leaving its future incomplete forever.
Fixes #1383