Repository navigation
fix(install): complete macOS setup, plus a double-clickable macOS app bundle - #6
fabio-krauss wants to merge 2 commits into
Conversation
Use the standard PyPI PyTorch wheel on Darwin, matching scripts/install_torch.py. The download.pytorch.org '+cpu' local-version builds are Windows/Linux only, so 'torch==2.13.0+cpu' from the cpu index never resolves on macOS and the script exited before installing any dependency. Also treat the llama.cpp wheel step as best-effort: the published arm64 wheels for 0.3.31-0.3.36 fail their CRC-32 checks, and the existing fallback was CUDA-only, so a corrupt wheel aborted the whole install on macOS. Try the newest compatible release, then the newest release known to have intact wheels, then the portable CPU index.
Build Meet2Notes.app from the existing source install with scripts/create_macos_app.sh: an .icns generated with sips/iconutil, an Info.plist and a launcher that resolves the checkout and runs .venv/bin/meet2notes. Finder launches get a usable PATH and a log file, and the bundle is unsigned and quarantine-free by construction. The bundle is a build artifact and stays gitignored. Windows already has start.bat; macOS previously had no launcher at all.
|
Thanks, Fabio, for the detailed report, the fixes, and the testing on your Mac — especially for tracing the wheel corruption upstream. The Darwin PyTorch fix looks good. Before merging, I’d like to address two points: preserve the project’s dependency constraints during the llama.cpp retries (particularly The Pinokio installation path mentioned in #5 also remains affected. Could we cover that too, or explicitly track it separately? Splitting the optional app bundle into a separate PR would help us land the installation fix independently. Thanks again for contributing and offering to test on macOS! |
What changed
Two commits, both aimed at making a fresh macOS install actually finish. Neither touches
src/, so behaviour on Windows/Linux is unchanged.1.
fix(install): complete macOS setup for PyTorch and llama.cpptorch==2.13.0, no--index-url), mirroring the branchscripts/install_torch.pyalready has. The+cpulocal-version builds only exist for Windows/Linux, sotorch==2.13.0+cpuagainst the cpu index never resolved on macOS andset -eaborted the script right after venv creation — before any dependency was installed. The CUDA path and the Windowsinstall.ps1behaviour are deliberately untouched.Content-Length, members failing CRC-32). The previous fallback only fired forAI_BACKEND=auto && LLAMA_BACKEND=cuda, so on macOS a corrupt wheel hitexit 1. Now the step tries the newest compatible release, then the newest release known to have intact wheels, then the portable CPU index, and only fails if all of them fail. Once fix(ci): prevent corrupted Metal wheel releases abetlen/llama-cpp-python#2379 lands the first attempt succeeds again and the pinned fallback is never reached.Fixes #5.
2.
feat(macos): a double-clickable app bundle and app iconmacOS had no launcher at all — no Dock icon, nothing in Finder, no
/Applicationsentry; Windows hasstart.bat.scripts/create_macos_app.shbuildsMeet2Notes.appfrom the existing source install using only tools that ship with macOS (sips,iconutil), with no new downloads:.icnsicon in every size macOS asks for, generated fromassets/macos/Meet2Notes-1024.pngInfo.plistand a launcher that resolves the checkout and execs.venv/bin/meet2notes, so the browser opens on127.0.0.1:8765as usualPATH(so Homebrew FFmpeg is found) and~/Library/Logs/Meet2Notes.logfor launches with no terminal attached--installalso copies it to/ApplicationsThe icon is a placeholder I drew, not a branding decision — replace
assets/macos/Meet2Notes-1024.pngwith whatever you prefer and the script regenerates everything from it. The.appis a build artifact and stays gitignored.Validation
bash -n install.shandbash -n scripts/create_macos_app.sh./install.sh --ai-backend auto --no-models→Meet2Notes is ready.pip check→ no broken requirements;check_environment.pyreports Python, platform and FFmpeg pathsHTTP 200onhttp://127.0.0.1:8765./scripts/create_macos_app.sh→ bundle built, launcher resolves the venv and runs the CLI (--helprouted to the log file)curl -L+zipfile.testzip()against 0.3.25/0.3.30 (intact) and 0.3.31–0.3.36 (corrupt), and reproduced with pip itselfruff/mypy/pytestare unaffected (no Python source changed). If you'd rather review these separately, say so and I'll split commit 2 into its own PR — and if you'd prefer the launcher to be a Pinokio/installer concern instead of a script in the repo, happy to move it.