Repository navigation
Tables: Add select all functionality & Unify copy and export selection behavior - #2650
Merged
Merged
Conversation
* Collect selected ids on click instead on every frame * Get all selected items counts directly instead of iteration
Export also follows current copy with exporting logs from search results only.
* Add action to select all logs for both tables context menu * Add shortcut to select all logs from the active table `Ctrl/Cmd + A` * Add Select all logs and search results to command palette. * Rename selection scope fields to main and search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2647
It adds functionality to select all logs in both main and search tables via:
Ctrl/Cmd + AIt also unify export and copy behavior for selection making export consider search results only when called from its table.
Also it provides performance fixes avoiding slow calls in render loop