Skip to content

ci: add test to conventional commit allowed types#1478

Merged
kolipakakondal merged 1 commit into
masterfrom
ci/add-test-conventional-commit-type
Jun 10, 2026
Merged

ci: add test to conventional commit allowed types#1478
kolipakakondal merged 1 commit into
masterfrom
ci/add-test-conventional-commit-type

Conversation

@kolipakakondal

@kolipakakondal kolipakakondal commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated pre-commit hook validation to version 1.7.0 with expanded support for additional conventional commit types.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c78281a8-e504-4f8a-a63e-f63260d152f9

📥 Commits

Reviewing files that changed from the base of the PR and between 68bce8d and 146a373.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Walkthrough

The PR updates the pre-commit configuration to upgrade the conventional-precommit-linter hook from v1.2.1 to v1.7.0 and adds explicit args to allow additional conventional commit types during commit message validation.

Changes

Pre-commit Hook Configuration Update

Layer / File(s) Summary
Conventional Linter Hook Upgrade
.pre-commit-config.yaml
The conventional-precommit-linter hook is bumped to v1.7.0 with new args configuration explicitly permitting standard conventional commit types (docs, style, refactor, perf, test, chore, ci, build, revert) for the commit-msg stage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • espressif/idf-eclipse-plugin#1324: Enhances workflow to run the conventional-precommit-linter hook during commit-msg validation, complementing this upgrade of the hook configuration and allowed types.

Suggested reviewers

  • sigmaaa
  • alirana01

Poem

🐰 A linter's dance, a version's leap,
From one point two to seven's keep,
New commit types now shine so bright,
Conventional messages polished right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'add test to conventional commit allowed types' but the actual change updates the pre-commit hook configuration to allow additional commit types (docs, style, refactor, etc.), not to add a test. Update the title to accurately reflect the change, such as 'ci: extend conventional commit allowed types in pre-commit hook' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/add-test-conventional-commit-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kolipakakondal kolipakakondal merged commit 87cba23 into master Jun 10, 2026
3 of 6 checks passed
@kolipakakondal kolipakakondal deleted the ci/add-test-conventional-commit-type branch June 10, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant