WIP: feat: reducing the size of update site and adding repository reference#1474
Open
sigmaaa wants to merge 6 commits into
Open
WIP: feat: reducing the size of update site and adding repository reference#1474sigmaaa wants to merge 6 commits into
sigmaaa wants to merge 6 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds Eclipse feature imports to the plugin feature manifest, refactors update-site category/repository definitions, introduces an offline Tycho update-site module, updates the releng aggregator POM, and changes CI to build/package/upload both online and offline update artifacts. ChangesEclipse Dependency and Repository Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@features/com.espressif.idf.feature/p2.inf`:
- Around line 1-3: Update the Eclipse repository stream in the p2.inf
instructions.configure entry so it matches the target platform stream: change
both addRepository(location:https${`#58`}//download.eclipse.org/releases/2025-12/)
occurrences to use download.eclipse.org/releases/2026-03/ (preserve the ${`#58`}
encoding and the type:0/type:1 entries); edit the instructions.configure line in
features/com.espressif.idf.feature/p2.inf where the
org.eclipse.equinox.p2.touchpoint.eclipse.addRepository calls are defined to
point to 2026-03.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 06e19b5a-1836-4e9d-bb62-5c3e8efca927
📒 Files selected for processing (1)
features/com.espressif.idf.feature/p2.inf
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@releng/com.espressif.idf.update/category.xml`:
- Line 13: category.xml is missing needed <repository-reference> entries for
dependencies declared by features/com.espressif.idf.feature/feature.xml (TM4E,
EmbedCDT, Nebula, CDT-LSP, SWTChart, LSP4E); add repository-reference elements
for the following URLs so provisioning can resolve those imports:
https://download.eclipse.org/tm4e/releases/0.17.2/,
https://download.eclipse.org/embed-cdt/updates/v6/,
http://download.eclipse.org/nebula/releases/latest,
https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.5/cdt-lsp-3.5.0/,
https://download.eclipse.org/swtchart/releases/1.0.0/repository/, and
https://download.eclipse.org/lsp4e/releases/0.30.0/ (place them alongside the
existing https://download.eclipse.org/releases/2026-03/ <repository-reference>
entry in releng/com.espressif.idf.update/category.xml).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f86107d-f725-4cc6-aa50-2095acd1e28d
📒 Files selected for processing (2)
features/com.espressif.idf.feature/feature.xmlreleng/com.espressif.idf.update/category.xml
| <category-def name="com.espressif.idf.dependencies" label="ESP-IDF Eclipse Plugin - Dependencies"/> | ||
| </site> | ||
|
|
||
| <repository-reference location="https://download.eclipse.org/releases/2026-03/" enabled="true" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
CATEGORY_FILE="$(fd -p 'category.xml' releng | grep 'com.espressif.idf.update/category.xml' | head -n1)"
FEATURE_FILE="$(fd -p 'feature.xml' features | grep 'com.espressif.idf.feature/feature.xml' | head -n1)"
TARGET_FILE="$(fd -p 'com.espressif.idf.target.target' releng | head -n1)"
echo "== category.xml repository references =="
rg -n '<repository-reference' "$CATEGORY_FILE"
echo
echo "== new requirements in feature.xml =="
rg -n 'tm4e|embedcdt|xviewer|cdt\.lsp|lsp4e|swtchart|launchbar|terminal' "$FEATURE_FILE"
echo
echo "== target-platform repos providing those families =="
rg -n -C2 'tm4e|embed-cdt|embedcdt|xviewer|nebula|cdt\.lsp|launchbar|terminal|releases/2026-03' "$TARGET_FILE"Repository: espressif/idf-eclipse-plugin
Length of output: 3915
🏁 Script executed:
#!/bin/bash
set -euo pipefail
TARGET_FILE="$(fd -p 'com.espressif.idf.target.target' releng | head -n1)"
FEATURE_FILE="$(fd -p 'feature.xml' features | grep 'com.espressif.idf.feature/feature.xml' | head -n1)"
echo "== target-platform entries for new requirements (repositories/locations) =="
rg -n -C2 'swtchart|lsp4e|launchbar|terminal|nebula|xviewer|embedcdt|tm4e|cdt\.lsp' "$TARGET_FILE"
echo
echo "== full list of added/required imports in feature.xml =="
rg -n 'org\.eclipse\.tm4e|org\.eclipse\.swtchart|org\.eclipse\.lsp4e|org\.eclipse\.cdt\.lsp|org\.eclipse\.embedcdt|org\.eclipse\.launchbar|org\.eclipse\.nebula\.widgets\.xviewer|org\.eclipse\.terminal\.feature' "$FEATURE_FILE"Repository: espressif/idf-eclipse-plugin
Length of output: 4131
Add missing p2 repository references for TM4E/EmbedCDT/Nebula CDT-LSP/SWTChart/LSP4E dependencies
releng/com.espressif.idf.update/category.xml only references https://download.eclipse.org/releases/2026-03/, but features/com.espressif.idf.feature/feature.xml now imports TM4E, SWTChart, LSP4E, CDT-LSP, EmbedCDT, and Nebula XViewer. Those are sourced from separate repositories in releng/com.espressif.idf.target/... and will be unresolved when provisioning from this update site unless matching <repository-reference> entries are added:
https://download.eclipse.org/tm4e/releases/0.17.2/https://download.eclipse.org/embed-cdt/updates/v6/http://download.eclipse.org/nebula/releases/latesthttps://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.5/cdt-lsp-3.5.0/https://download.eclipse.org/swtchart/releases/1.0.0/repository/https://download.eclipse.org/lsp4e/releases/0.30.0/
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@releng/com.espressif.idf.update/category.xml` at line 13, category.xml is
missing needed <repository-reference> entries for dependencies declared by
features/com.espressif.idf.feature/feature.xml (TM4E, EmbedCDT, Nebula, CDT-LSP,
SWTChart, LSP4E); add repository-reference elements for the following URLs so
provisioning can resolve those imports:
https://download.eclipse.org/tm4e/releases/0.17.2/,
https://download.eclipse.org/embed-cdt/updates/v6/,
http://download.eclipse.org/nebula/releases/latest,
https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.5/cdt-lsp-3.5.0/,
https://download.eclipse.org/swtchart/releases/1.0.0/repository/, and
https://download.eclipse.org/lsp4e/releases/0.30.0/ (place them alongside the
existing https://download.eclipse.org/releases/2026-03/ <repository-reference>
entry in releng/com.espressif.idf.update/category.xml).
Source: Learnings
sigmaaa
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@releng/pom.xml`:
- Around line 16-17: The parent aggregator lists a non-existent Maven module
com.espressif.idf.update.offline1, causing reactor build failures; fix by either
removing the com.espressif.idf.update.offline1 <module> entry from the parent
POM or by creating the missing module directory named
com.espressif.idf.update.offline1 with a valid pom.xml (matching
groupId/artifactId and parent reference) so the module can be built, and ensure
the new module is referenced correctly in the parent modules section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e559ff03-cbbd-4d7f-a447-ce571e8ed691
📒 Files selected for processing (8)
.github/workflows/ci_release.ymlreleng/com.espressif.idf.update.offline/.gitignorereleng/com.espressif.idf.update.offline/.projectreleng/com.espressif.idf.update.offline/.settings/org.eclipse.core.resources.prefsreleng/com.espressif.idf.update.offline/.settings/org.eclipse.m2e.core.prefsreleng/com.espressif.idf.update.offline/category.xmlreleng/com.espressif.idf.update.offline/pom.xmlreleng/pom.xml
✅ Files skipped from review due to trivial changes (5)
- releng/com.espressif.idf.update.offline/.gitignore
- releng/com.espressif.idf.update.offline/.project
- releng/com.espressif.idf.update.offline/.settings/org.eclipse.core.resources.prefs
- releng/com.espressif.idf.update.offline/.settings/org.eclipse.m2e.core.prefs
- releng/com.espressif.idf.update.offline/pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
New Features
Chores