Skip to content

Accept per-tenant integration slug on /os/provision #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darjss wants to merge 1 commit into from
Closed

Accept per-tenant integration slug on /os/provision #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions apps/host-cloudflare/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const accessConfigErrorResponse = (missingVars: readonly string[]): Response =>
},
});

const ERXES_INTEGRATION = "erxes-officenext";
const DEFAULT_ERXES_INTEGRATION = "erxes-officenext";

const executorRequest = (
original: Request,
Expand All @@ -62,19 +62,31 @@ const executorRequest = (
});
};

const parseIntegrationSlug = (raw: unknown): string | null => {
if (raw === undefined || raw === null || raw === "") return DEFAULT_ERXES_INTEGRATION;
if (typeof raw !== "string" || !/^[a-z0-9][a-z0-9-]*$/.test(raw)) return null;
return raw;
};

const provisionErxes = async (
request: Request,
app: (request: Request) => Promise<Response>,
): Promise<Response> => {
if (request.method !== "POST") return new Response("Method Not Allowed", { status: 405 });

let input: { endpoint?: unknown; cookie?: unknown };
let input: { endpoint?: unknown; cookie?: unknown; integration?: unknown };
// oxlint-disable-next-line executor/no-try-catch-or-throw -- boundary: malformed external JSON becomes a 400 response
try {
input = (await request.json()) as { endpoint?: unknown; cookie?: unknown };
input = (await request.json()) as {
endpoint?: unknown;
cookie?: unknown;
integration?: unknown;
};
} catch {
return new Response("Invalid request", { status: 400 });
}
const integration = parseIntegrationSlug(input.integration);
if (integration === null) return new Response("Invalid request", { status: 400 });
if (
typeof input.endpoint !== "string" ||
typeof input.cookie !== "string" ||
Expand All @@ -86,16 +98,16 @@ const provisionErxes = async (
}

const existing = await app(
executorRequest(request, `/api/graphql/integrations/${ERXES_INTEGRATION}`, "GET"),
executorRequest(request, `/api/graphql/integrations/${integration}`, "GET"),
);
if (!existing.ok) return existing;
if ((await existing.json()) === null) {
const created = await app(
executorRequest(request, "/api/graphql/integrations", "POST", {
endpoint: input.endpoint,
slug: ERXES_INTEGRATION,
name: "OfficeNext",
description: "OfficeNext Erxes GraphQL API",
slug: integration,
name: integration,
description: `${integration} Erxes GraphQL API`,
authenticationTemplate: [
{
slug: "cookie",
Comment on lines +109 to 113

@sourcery-ai sourcery-ai Bot Aug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (broader_impact): The default erxes-officenext provisioning no longer preserves the existing OfficeNext-facing metadata: the integration name, description, connection name, identity label, and connection description become erxes-officenext-based values instead of OfficeNext/Your OfficeNext account. This breaks the stated compatibility guarantee that officenext remains unchanged and changes the labels shown to existing internal SSO users.

Triggers: When integration is omitted and the default OfficeNext integration is provisioned or its connection is refreshed.

Suggested fix: Keep the legacy OfficeNext metadata when integration === DEFAULT_ERXES_INTEGRATION, and use slug-derived metadata only for custom integrations.

Expand All @@ -111,12 +123,12 @@ const provisionErxes = async (
return app(
executorRequest(request, "/api/connections", "POST", {
owner: "user",
name: ERXES_INTEGRATION,
integration: ERXES_INTEGRATION,
name: integration,
integration,
template: "cookie",
value: input.cookie,
identityLabel: "OfficeNext",
description: "Your OfficeNext account",
identityLabel: integration,
description: `Your ${integration} account`,
}),
);
};
Expand Down
Loading