Repository navigation
Fix random_exponential backoff start and returned wait - #556
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
random_exponentialbackoff started with the state{Lower, Lower}instead of{Min, Lower}, as indb_connection. Because of this, the first retry came after 10 to 30 seconds with the defaults, not after 1 to 3 seconds. The function also returned a second random value instead of the wait it stored as the previous wait. Thus each new range used a wait that did not occur.This change makes both match
db_connection. A new test checks that the first wait is betweenbackoff_minand three timesbackoff_min.Fixes #555