Repository navigation
ADR 0017: Abstract classes for the extension points - #18
Merged
Merged
Conversation
WP_Secrets_Provider, WP_Secrets_Store and WP_Secrets_Keyring become abstract classes, so a later release can add a method with a default implementation without breaking drop-ins. Proposed in core as WordPress/wordpress-develop#15744, after #66187 comment:45. src/ and the examples change when core commits it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. Records the decision to make
WP_Secrets_Provider,WP_Secrets_StoreandWP_Secrets_Keyringabstract classes instead of interfaces, so a later release can add a method with a default implementation without breaking every drop-in.src/,examples/and the spec pages change when core commits it, as with ADR 0016.