Repository navigation
fix: three verdict-changing findings from PR #268 (#270) - #271
Conversation
Setup keeps every provider's writer setting line, and the configure case's preparation removes only Codex's. The case now compares only Codex's line, so an operator sheet with another provider's line passes. Refs #270 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A change to features/recipes.ts can name any feature that has a recipe, and writers has one, so the shared-recipe expansion now selects it. Refs #270 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agy's notes still named the agent pstack-read-only and said its tools list strips web, browser and subagent tools. The runner passes `--agent pstack-lane`, and Antigravity CLI 1.5.2 ignores the list; only 1.3.6 honoured it. Regenerated model-catalog.md. Refs #270 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 Queue ready pull requestsAutomatically queue non-draft pull requests targeting main after verify and live-gate pass on the head and every review thread is resolved.
🟢 🚦 Auto-queueWhen all merge protections are satisfied and these conditions match, this pull request will be queued automatically.
|
|
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryThis PR fixes two live-gate checks and corrects Antigravity’s catalog notes.
No actionable defects were found. Tests were not run during this review. Acknowledgment: Reviews (1) · Last reviewed commit: "fix(catalog): name agy's pstack-lane age..." · Reviewed by Greptile |
Live evidence: Open Pstack
|
✅ No blocking findingsWalkthroughThis PR fixes three defects found in review of PR
Advisories (1)
Details
First review of this pull request. @unfret review · @unfret status · @unfret help |
Live evidence: Open Pstack
|
✅ Merged into
|
Why
Unfret's review of PR #268 found three defects that change a verdict: two in the live-gate verifier and one wrong disclosure in Antigravity's catalog note. This fixes them forward, as the repository's land-on-green policy says. Fixes #270.
Summary
Evidence
scripts/catalog.test.tswith a sheet holdingmuse writer sandbox: full-accessand Codex's line. Before (feat(runner): writers for external providers and a Muse Code provider (#263, #258) #268's code):setting-not-full-access, 1 fail. After: 3 pass.core.test.tsnow expectswriters. Before:claude:writersandcodex:writersmissing, 1 fail. After: 2 pass.pstack-read-onlyor unconditional tool-removal claim remains inplugins/or.claude/.claude:setup(the configure case) andcodex:catalog(the agy note), with--self-testbecause the verifier changes.Merge Danger
Door: two-way
Blast Radius: verifier and docs
Acceptance criteria
Unfret dispositions on #268's merged head:
233d6c57,857b2c9a,35b3cceband3e266693(same root as35b3cceb) are fixed here.Gate results
On
4e28148:bun run test0,bun run typecheck0,bun run static0,claude plugin validate plugins/pstack0. No comments added.Introduced by: #268
🤖 Generated with Claude Code