Skip to content

fix: three verdict-changing findings from PR #268 (#270) - #271

Merged
mergify[bot] merged 3 commits into
mainfrom
fix/270-pr268-findings
Nov 6, 2026
Merged

mergify[bot] merged 3 commits into
mainfrom
fix/270-pr268-findings

Conversation

@ericlitman

Copy link
Copy Markdown
Owner

Why

Unfret's review of PR #268 found three defects that change a verdict: two in the live-gate verifier and one wrong disclosure in Antigravity's catalog note. This fixes them forward, as the repository's land-on-green policy says. Fixes #270.

Summary

 verify-open-pstack
   features/recipes.ts  configure case
-    settingLines(text) must equal [codex full-access line]
+    the Codex lines of settingLines(text) must equal it       # other providers' lines are preserved by setup
   scripts/core.ts
-    if (sharedRecipe) both('catalog')
+    if (sharedRecipe) both('catalog', 'writers')             # a recipes-only PR can name writers
 runner/providers/agy.ts  (catalog notes, regenerated)
-  --agent pstack-read-only; "the run-owned agent limits only the lane's tools"
+  --agent pstack-lane; agy 1.5.2 ignores the agent's tools list (only 1.3.6 honoured it)

Evidence

  • Configure case: new test in scripts/catalog.test.ts with a sheet holding muse writer sandbox: full-access and Codex's line. Before (feat(runner): writers for external providers and a Muse Code provider (#263, #258) #268's code): setting-not-full-access, 1 fail. After: 3 pass.
  • Shared-recipe reach: the existing table test in core.test.ts now expects writers. Before: claude:writers and codex:writers missing, 1 fail. After: 2 pass.
  • Agy note: no pstack-read-only or unconditional tool-removal claim remains in plugins/ or .claude/.
  • Live gate: pending. Features: claude:setup (the configure case) and codex:catalog (the agy note), with --self-test because the verifier changes.

Merge Danger

Door: two-way

Blast Radius: verifier and docs

Acceptance criteria

Unfret dispositions on #268's merged head: 233d6c57, 857b2c9a, 35b3cceb and 3e266693 (same root as 35b3cceb) are fixed here.

Gate results

On 4e28148: bun run test 0, bun run typecheck 0, bun run static 0, claude plugin validate plugins/pstack 0. No comments added.

Introduced by: #268

🤖 Generated with Claude Code

ericlitman and others added 3 commits November 6, 2026 10:59
Setup keeps every provider's writer setting line, and the configure case's
preparation removes only Codex's. The case now compares only Codex's line,
so an operator sheet with another provider's line passes.

Refs #270

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A change to features/recipes.ts can name any feature that has a recipe,
and writers has one, so the shared-recipe expansion now selects it.

Refs #270

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agy's notes still named the agent pstack-read-only and said its tools
list strips web, browser and subagent tools. The runner passes
`--agent pstack-lane`, and Antigravity CLI 1.5.2 ignores the list; only
1.3.6 honoured it. Regenerated model-catalog.md.

Refs #270

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mergify

mergify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 2 merge protections satisfied — ready to merge.

Show 2 satisfied protections

🟢 Queue ready pull requests

Automatically queue non-draft pull requests targeting main after verify and live-gate pass on the head and every review thread is resolved.

  • #review-threads-unresolved = 0
  • -draft
  • check-success=live-gate
  • check-success=verify

🟢 🚦 Auto-queue

When all merge protections are satisfied and these conditions match, this pull request will be queued automatically.

  • -files~=^\.github/
  • base = main

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

RetriggerView in Greptile

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

This PR fixes two live-gate checks and corrects Antigravity’s catalog notes.

  • The setup check allows other providers’ writer settings to stay in the sheet.
  • Shared recipe changes now select writer checks as well as catalog checks.
  • Antigravity notes name pstack-lane and describe its tool limits by CLI version.

No actionable defects were found. Tests were not run during this review.

Acknowledgment: ericlitman explicitly states that item 4 from PR #268 receives no repair because it fails loudly. This review does not reopen that deferred item.

Reviews (1) · Last reviewed commit: "fix(catalog): name agy's pstack-lane age..." · Reviewed by Greptile

@ericlitman

Copy link
Copy Markdown
Owner Author

Live evidence: Open Pstack

  • Candidate SHA: 4e2814893c9605ed90896131f7cbab468995a6f3
  • Base SHA: 1d0a0b0b95fd4af946d47dd5449b496ca72dd148
  • Result: FAILED — verification did not complete; rerun required
  • Self-test: required in both harnesses
  • Planned sessions: 12 (limit 12)
  • Publisher revision: 4e2814893c9605ed90896131f7cbab468995a6f3
  • Evidence-set SHA-256: 4e2b6d073a6f803760b4360c0988e5c06c18f5cf338e2207528ca8735df7849d
  • Policy: every new head requires a fresh run; this verifier does not change PR state, queue, or merge.

@unfret-eal

unfret-eal Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

✅ No blocking findings

Walkthrough

This PR fixes three defects found in review of PR #268: two in the live-gate verifier and one inaccurate note about Antigravity (agy) in the model catalog. The verifier's configure case now checks only the Codex writer-setting lines, so lines setup preserves for other providers no longer fail it. A change to the shared recipes file now also triggers the `writers` features. The agy catalog note now names the `pstack-lane` agent and says agy 1.5.2 ignores the agent's `tools` list, which only 1.3.6 honoured. The PR adds or updates a test for each verifier fix, and the author reports local gates passing with the live gate still pending. One low-severity finding remains: the documentation of configure coverage is now inaccurate.

Area What changes
Verifier configure case Filters the sheet's setting lines to Codex's prefix before comparing them with the full-access line, and adds a test whose sheet also holds a `muse writer sandbox` line.
Verifier feature classification A change to `features/recipes.ts` now adds `writers` alongside `catalog` for both providers, and the table test is updated to expect it.
Agy catalog note Corrects the agent name to `pstack-lane`, describes the per-lane `tools` list, and removes the claim that the run-owned agent limits the lane's tools. The note is changed in both `agy.ts` and `model-catalog.md`.
Advisories (1)
  • 🔵 Low · Configure coverage documentation is now inaccurate · .claude/skills/verify-open-pstack/features/recipes.ts:486
    With an existing Muse setting, `configure` now succeeds with both Muse and Codex setting lines, as the new regression test confirms. However, `.claude/skills/verify-open-pstack/features/setup.md` still says this case asserts “exactly one setting line, `codex writer sandbox: full-access`”. This leaves verifier operators with a false description of the check’s coverage. Update that definition to describe exactly one Codex setting line while allowing other providers’ settings.
    Not blocking because: The confirmed mismatch concerns the prose description of setting-line cardinality. The executable check and published assertion remain Codex-specific and correct; allowing preserved provider settings does not invalidate the behavior being verified.
Details
Lane / stage Model Effort Outcome Duration
broad-gpt-5.6-sol-xhigh / review openai/gpt-5.6-sol → gpt-5.6-sol · primary xhigh succeeded 1 min 4 s
broad-opus-5.5-max / review anthropic/claude-opus-5-5 → claude-opus-5-5 · primary max succeeded 4 min 7 s
focal-gpt-5.6-sol-xhigh copy / review openai/gpt-6.1-sol → gpt-6.1-sol · primary xhigh succeeded 8 min 40 s
focal-gpt-5.6-sol-xhigh copy 2 / review openai/gpt-6.1-sol → gpt-6.1-sol · primary xhigh succeeded 6 min 25 s
judge / judge openai/gpt-6-astra → gpt-6-astra · primary high succeeded 1 min 32 s

First review of this pull request.
4 reviewers finished.
Commit 4e28148.
Check run.
Run: GET /unfret/run/panel:4e2814893c9605ed90896131f7cbab468995a6f3:GhdcAY2QBRe:NEFAZ2QV1UY.

@unfret review · @unfret status · @unfret help

@unfret-eal unfret-eal Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No blocking findings
Check

@ericlitman

Copy link
Copy Markdown
Owner Author

Live evidence: Open Pstack

  • Candidate SHA: 4e2814893c9605ed90896131f7cbab468995a6f3
  • Base SHA: 1d0a0b0b95fd4af946d47dd5449b496ca72dd148
  • Result: PASSED — named features verified
  • Self-test: completed in both harnesses
  • Planned sessions: 12 (limit 12)
  • Publisher revision: 4e2814893c9605ed90896131f7cbab468995a6f3
  • Evidence-set SHA-256: 6cc6f33c228ab436221d7b9075b3a1e2493fe9cac88207558375986de5e8abff
  • Installation (claude): CLI 2.1.318 (Claude Code), plugin 1.18.0, candidate 4e2814893c9605ed90896131f7cbab468995a6f3, tree 376a7552f4dbe87dcaea14a00966749699afb29537f08e5bf2109b64fec27a7f.
  • Installation (codex): CLI codex-cli 0.167.0, plugin 1.18.0, candidate 4e2814893c9605ed90896131f7cbab468995a6f3, tree 376a7552f4dbe87dcaea14a00966749699afb29537f08e5bf2109b64fec27a7f.
  • Observation (claude / project-skill): surface claude -p stream-json with the candidate plugin-dir; action recipe project-skill: doctor; result passed: doctor:exit-0 doctor:skill-loaded doctor:doctor-ran doctor:doctor-canonical-pass; 4 assertions machine-checked; transcript SHA-256 b51da7e1f2fd5dff4ca08d416d31a9c82e3b29f5c1bbabbb8596eaf4bde4d328; artifact-set SHA-256 af12f550909a79a8a1921ec41947657461c8259b4ea952884f183a324d14ba93.
  • Observation (claude / setup): surface claude -p stream-json with the candidate plugin-dir; action recipe setup: configure, consume, keep-predecessor, new-families, read-only-provider, writer-refusal, keep-setting, first-run; result passed 41 assertions; ids retained privately; 41 assertions machine-checked; transcript SHA-256 9b8f3fc359f9230342067c70859dc12f5500b1656b8d7eb905aa6bf719bafd3a; artifact-set SHA-256 825936b1fd519d8b2720bea396eef2c0b7bf96cd3709f49ede38f01538646092.
  • Observation (codex / catalog): surface codex exec --json with the run-owned candidate installation; action recipe catalog: consume-sheet, consume-sheet-bounded; result passed 24 assertions; ids retained privately; 24 assertions machine-checked; transcript SHA-256 1a336e03e2820c45c40aec8af331699f7ddc2c7506f87e8e6fd066731087533e; artifact-set SHA-256 5d6bf336608985153a49b62a13d97818bfa1f37acb969d5f34780cdcef7e12f9.
  • Observation (codex / project-skill): surface codex exec --json with the run-owned candidate installation; action recipe project-skill: doctor; result passed: doctor:exit-0 doctor:skill-loaded doctor:doctor-ran doctor:doctor-canonical-pass; 4 assertions machine-checked; transcript SHA-256 c4d941baf109a64bd5b5257ed29f5f7212692c3f1f785d65e6a7cc27227c83ef; artifact-set SHA-256 09efcf89a63d83aec6d0adb555a9812eee5e70c6f0e84d7042b0abb4b70a241f.
  • Policy: every new head requires a fresh run; this verifier does not change PR state, queue, or merge.

@mergify
mergify Bot merged commit b411250 into main Nov 6, 2026
8 checks passed
@mergify

mergify Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

✅ Merged into main as b411250 at 16:32 UTC

Less than a minute in the queue, with no time running CI.

So far

  • ✅ Entered the queue Fri 6 Nov, 16:32 · rule default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged 16:32 · b411250 · merge
8 merge conditions met
  • github-review-approved · required by GitHub repository ruleset rule Protect main
  • #review-threads-unresolved = 0 · required by Merge Protections rule Queue ready pull requests
  • -draft · required by Merge Protections rule Queue ready pull requests
  • check-success=live-gate · required by Merge Protections rule Queue ready pull requests
  • check-success=verify · required by Merge Protections rule Queue ready pull requests
  • any of · required by GitHub repository ruleset rule Protect main:
    • check-success = @github-actions/verify
    • check-neutral = @github-actions/verify
    • check-skipped = @github-actions/verify
  • any of · required by GitHub repository ruleset rule Protect main:
    • check-success = live-gate
    • check-neutral = live-gate
    • check-skipped = live-gate
  • any of · required by GitHub repository ruleset rule Review gate:
    • check-success = @mergify/Mergify Merge Protections
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections

Times in UTC · dashboard · how the merge queue works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the four blocking findings from PR #268's review

1 participant