Skip to content

fix: write updated config back to mounted file on configmap reload #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: write updated config back to mounted file on configmap reload #1233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,15 @@ func startConfigWatch(cancel context.CancelFunc, watcher *inotify.Watcher, erase
continue
}

// Write the updated configuration back to the mounted file so that
// containers (e.g. trivy scanner) reading the config file see the
// updated values instead of the stale file on disk.
if updatedBytes, err := yaml.Marshal(newConfig); err != nil {
setupLog.Error(err, "failed to marshal updated configuration")
} else if err = os.WriteFile(filename, updatedBytes, 0644); err != nil {
setupLog.Error(err, "failed to write updated configuration to file")
}

// read back the new configuration
*newConfig, err = eraserOpts.Read()
if err != nil {
Expand Down