Skip to content

fix(trivy): fail fast when trivy binary is not found #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(trivy): fail fast when trivy binary is not found #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79b07e7
fix(trivy): fail fast when trivy binary is not found
AruneshDwivedi Aug 15, 2026
03c0325
fix: add CRI connection timeout and trivy binary pre-flight check
AruneshDwivedi Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/scanners/trivy/trivy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ func main() {
log.Info("trivy version", "trivy version", trivyVersion)
log.Info("config", "config", *config)

if _, err := os.Stat(trivyCommandName); err != nil {
if os.IsNotExist(err) {
fmt.Fprintf(os.Stderr, "trivy binary not found at %s\n", trivyCommandName)
os.Exit(generalErr)
}
log.Error(err, "unable to stat trivy binary")
os.Exit(generalErr)
}

userConfig := *DefaultConfig()
if *config != "" {
var err error
Expand Down
7 changes: 6 additions & 1 deletion pkg/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ func GetConn(ctx context.Context, socketPath string) (conn *grpc.ClientConn, err
return nil, err
}

// Use a timeout context so we fail fast instead of hanging indefinitely
// when the CRI socket is inaccessible (e.g. permission denied).
connCtx, cancel := context.WithTimeout(ctx, 30*time.Second)
defer cancel()

//nolint:staticcheck // SA1019: grpc.DialContext is deprecated but maintains required blocking behavior
return grpc.DialContext(
ctx,
connCtx,
addr,
//nolint:staticcheck // SA1019: grpc.WithBlock is deprecated but ensures synchronous CRI connection
grpc.WithBlock(),
Expand Down