security: mask sensitive passwords and API keys in Django Admin#890
Open
Sweekar-m wants to merge 1 commit into
Open
security: mask sensitive passwords and API keys in Django Admin#890Sweekar-m wants to merge 1 commit into
Sweekar-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security vulnerability where sensitive operator credentials (LinkedIn passwords, SMTP passwords, LLM API keys, BetterContact API keys, and central contact API tokens) are exposed in clear text within Django Admin change views.
Changes
ModelFormdefinitions (SiteConfigForm,LinkedInProfileForm,MailboxForm) utilizingforms.PasswordInput(render_value=True)widgets for all secret/credential fields.SiteConfigAdmin,LinkedInProfileAdmin,MailboxAdmin).list_displaysettings to guarantee that raw passwords and API keys are never exposed in list columns.Verification
pytestsuccessfully).