Skip to content

Fix/filter/max depth observable #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eikeland merged 2 commits into from
Aug 3, 2026
Merged

Fix/filter/max depth observable #3333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0041e8f
fix(filter): refactor selected count calculation in FilterOptionHeader
eikeland Aug 3, 2026
0318e17
fix(filter): prevent infinite render loop in FilterOptionHeader
eikeland Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stable-filter-selector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@equinor/fusion-react-filter": patch
---

Prevent `FilterOptionHeader` from entering an infinite render loop after upgrading `@equinor/fusion-observable` by keeping its selection count selector stable across renders.
4 changes: 3 additions & 1 deletion packages/filter/src/components/filter/FilterOptionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ type FilterHeaderProps = {
readonly title: string;
};

const getSelectedCount = (selection?: Set<unknown>): number => selection?.size ?? 0;

const Styled = {
Root: styled.div`
display: flex;
Expand Down Expand Up @@ -63,7 +65,7 @@ export const FilterOptionHeader = (props: FilterHeaderProps): ReactElement => {
const { options$, selection$ } = useFilterOptionContext();
const optionCount = Object.keys(useObservableState(options$).value || {}).length;
const { value: selectedCount } = useObservableState(
useObservableSelector(selection$, (x) => (x ?? new Set()).size),
useObservableSelector(selection$, getSelectedCount),
{ initial: 0 },
);

Expand Down
Loading