Add github workflow - #2
Merged
Merged
Conversation
simon-ess
force-pushed
the
github_workflow
branch
from
September 14, 2026 12:17
877b087 to
3d814e3
Compare
Contributor
Author
|
pre-commit.ci run |
simon-ess
requested review from
daneos,
dharaujo,
lucianocguedes,
lucmaga and
pgap
September 14, 2026 12:36
lucmaga
requested changes
Sep 16, 2026
lucmaga
left a comment
lucmaga
left a comment
Contributor
There was a problem hiding this comment.
LGTM after changes.
I really like that we are using epics-base/ci-scripts
simon-ess
force-pushed
the
github_workflow
branch
from
September 16, 2026 13:44
2366cf4 to
f468cce
Compare
lucmaga
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few comments: I am skipping the shellcheck/shellformat for now: we have exactly one file that this touches.
There are of course no tests that this runs; this just runs a naïve build and calls it a day. This is a known issue in require3 unfortunately.