Repository navigation
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ddc456c2a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10334 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 277 277
Lines 44014 44019 +5
=======================================
+ Hits 36181 36187 +6
+ Misses 7832 7831 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…te ancestors Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
/retest |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
/retest |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1684ca0c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05c9852468
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| policyStatus := ExtServerPolicyStatusAsPolicyStatus(policy) | ||
| gatewayNN := utils.NamespacedName(gtwCtx) | ||
| ancestorRef := getAncestorRefForPolicy(gatewayNN, p.SectionName) | ||
| ancestorRef := parentRefCtx.PolicyAncestorRef() |
There was a problem hiding this comment.
When an extension-server policy (for example, via a target selector) covers 17 or more routes whose parentRefs select distinct ports, this port-preserving reference makes SetConditionForPolicyAncestor retain one ancestor per port. That setter intentionally allows 17 entries so a later TruncatePolicyAncestors call can add the Aggregated condition, but ProcessExtensionServerPolicies returns without the truncation performed by the typed policy processors; the emitted status can therefore exceed the Gateway API limit of 16 ancestors and be rejected by a policy CRD using the standard status schema. Truncate the converted unstructured policy statuses before returning them.
Useful? React with 👍 / 👎.
Depends on #10315 , needs to rebase after merging #10315.
What this PR does / why we need it:
The ancestor that a route policy reports for a route parentRef keeps the parentRef's
sectionNamebut not itsport, andancestorRefsEqualdoes not comparePort. So when a route has parentRefs to the same Gateway or ListenerSet that differ only byport, a policy targeting the route reports a single ancestor for all of them, although each parentRef attaches to different listeners. The route status already reports these parentRefs separately (#10004).This PR keeps the parentRef's
portin that ancestor, so each parentRef gets its own ancestor, as parentRefs that differ bysectionNamealready do.Today the shared ancestor loses nothing, since without
mergeTypethe same result goes to every ancestor, and withmergeTypethe merge results go on per-listener ancestors (#10314). With #10315, which reports the merge results on the parentRef's ancestor, each parentRef merges with the parent policy of its own listeners, so without this fix only the last parentRef's result would remain.Which issue(s) this PR fixes:
Fixes #10333
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.