Skip to content

fix(miners): case-insensitive joins for review_summary and repos #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiannidev wants to merge 1 commit into
base: test
Choose a base branch
from
Open

fix(miners): case-insensitive joins for review_summary and repos #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/das/src/api/miners/miners.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,10 @@ export class MinersService {
SELECT${PR_SELECT_COLUMNS}
FROM pull_requests p
LEFT JOIN pr_review_summary rs
ON rs.repo_full_name = p.repo_full_name
ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name)
AND rs.pr_number = p.pr_number
LEFT JOIN repos r
ON r.repo_full_name = p.repo_full_name
ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name)
LEFT JOIN maintainers m_author
ON m_author.github_id = p.author_github_id
AND m_author.repo_full_name = LOWER(p.repo_full_name)
Expand Down Expand Up @@ -301,10 +301,10 @@ export class MinersService {
JOIN windows w
ON w.repo_full_name = LOWER(p.repo_full_name)
LEFT JOIN pr_review_summary rs
ON rs.repo_full_name = p.repo_full_name
ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name)
AND rs.pr_number = p.pr_number
LEFT JOIN repos r
ON r.repo_full_name = p.repo_full_name
ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name)
LEFT JOIN maintainers m_author
ON m_author.github_id = p.author_github_id
AND m_author.repo_full_name = LOWER(p.repo_full_name)
Expand Down
Loading