Skip to content

[LOW] Redact process secrets from diagnostics #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[LOW] Redact process secrets from diagnostics #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/childprocess/abstract_process.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def leader?
end

def log(*args)
ChildProcess.logger.debug "#{self.inspect} : #{args.inspect}"
ChildProcess.logger.debug "#{self.class}(pid=#{@pid.inspect}) : #{args.inspect}"
end

def assert_started
Expand Down
7 changes: 5 additions & 2 deletions lib/childprocess/process_spawn_process.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ def launch_process
key = key.to_s
value = value.nil? ? nil : value.to_s

if key.include?("\0") || key.include?("=") || value.to_s.include?("\0")
raise InvalidEnvironmentVariable, "#{key.inspect} => #{value.to_s.inspect}"
if key.include?("\0") || key.include?("=")
raise InvalidEnvironmentVariable, "invalid environment variable name: #{key.inspect}"
end
if value.to_s.include?("\0")
raise InvalidEnvironmentVariable, "invalid value for environment variable #{key.inspect}"
end
environment[key] = value
end
Expand Down