Repository navigation
Find the dialogue of any typed DialogueResource property in the cue e… - #3066
Merged
Merged
Conversation
…ditor The inspector plugin shows the cue editor for a dialogue_cue property when the object has a dialogue property, which it recognizes with _is_dialogue_resource_property(): any property typed as DialogueResource, whatever its name. But the cue editor then looks for the dialogue in _get_resource() with a narrower check, which only matches some property names. So for a property like `@export var dialogue: DialogueResource`, the cue editor is shown but lists no cues. This change makes _get_resource() also accept properties with hint_string "DialogueResource", the same check that the inspector plugin uses to decide to show the cue editor. Helps #3065
Collaborator
Author
|
This is the patch I'll try to upstream. I'm merging it separately in case we have to maintain it. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/dialogue-cue-dropdown/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ditor
The inspector plugin shows the cue editor for a dialogue_cue property when the object has a dialogue property, which it recognizes with _is_dialogue_resource_property(): any property typed as DialogueResource, whatever its name. But the cue editor then looks for the dialogue in _get_resource() with a narrower check, which only matches some property names. So for a property like
@export var dialogue: DialogueResource, the cue editor is shown but lists no cues.This change makes _get_resource() also accept properties with hint_string "DialogueResource", the same check that the inspector plugin uses to decide to show the cue editor.
Helps #3065