Repository navigation
Conversation
Run the maintained Karma suites and production application build through one verification command and GitHub Actions. Remove the unused Protractor target and obsolete starter tests, and use the console reporter without its unused HTML-reporter dependency. Preserve upstream dependency versions and release metadata.
Add an assigned-character panel for host-provided HP ranges, pre-combat initiative, enabled effects, sheets, and rolls. Keep live player state reactive in the zoneless client and preserve upstream token status-effect rendering and typed models. Add local precise/grid rulers, session-local saved measurements, and area previews using the existing Pixi grid and area renderers. Refresh their grid settings with map updates and release replaced preview graphics. These tools do not write shared measurements or area effects. Add automatic/light/dark appearance, independent draggable character and reference windows, a right/bottom initiative dock, and turn notices. Preserve stored settings, bound window stacking, and handle inaccessible cross-origin frames. All 263 unit tests and the production build pass through the canonical verification script.
Describe the assigned-character controls, local ruler and area previews, floating sheets, appearance settings, and initiative dock. Explain the existing combatant/message WebSocket events and same-origin sheet interaction requirement, and document the canonical verification command without fork branding or version changes.
Saharory
marked this pull request as ready for review
October 4, 2026 03:08
The label graphic also draws the full colored disc when a token has no artwork. Its label-layer stacking placed the token body over the status-effect badges. Draw that body below overlays and effects while retaining the foreground label layer for artwork and tracked tokens. Add regressions for friendly and hostile plain tokens and for the transition from artwork to a plain disc. The regression fails before the fix and passes afterward; all 266 unit tests and the production build pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players can inspect and update their assigned character, plan distances and areas on the map, and keep sheets and references open independently. This contribution adds those tools alongside appearance settings and initiative docking, using the current upstream Angular/Pixi architecture.
Player features
Integration
Based on official develop at fcebe0a, including the token status-effect renderer. It retains AppModule declarations, zoneless signal-driven application updates, the data service, existing model/event paths, and the video-aware asset pipeline. A revision input refreshes the player panel when mutable API/WebSocket state changes.
HP and initiative use the documented updateCombatant WebSocket event; rolls use createMessage. Rulers and area previews stay local to the browser and do not create shared host objects. Integration with the new shared measurement/area-effect write endpoints remains a separate follow-up. Incoming host measurements and area effects retain their existing rendering paths.
Status effects remain typed and synchronize across the game combatant, token model, and rendered token. Suspended effects are excluded consistently. Plain colored token discs render beneath the status-effect badges; artwork tokens retain their foreground labels. Local rulers refresh after grid changes; floating-window stacking stays bounded; cross-origin sheets clear their loading state even when their documents cannot be inspected.
Validation
Four commits with explanatory bodies separate verification tooling, client behavior, documentation, and the effect-badge layering fix. Upstream branding, version 0.9.17, and production dependency versions are retained.
API compatibility was checked against the official server API and status-effect schema.