Repository navigation
Conversation
This reverts commit ef2e622.
- Drop install-basic-packages from prepare-for-tests and ubuntu-latest jobs (only needed on minimal self-hosted build-linux container; also drop clang and pkg-config from apt install). - Remove redundant V8 reinstall steps in test-wasm64-4gb, test-wasm64-misc, and test-esm-integration since ~/.jsvu is already restored from emscripten-cache.tar.gz. - Remove actions-cache-folder: 'emsdk-install' from setup-emsdk now that sanity.txt uses $EMSDK/upstream/bin. - Match build-linux embuilder build ALL + test_hello_world sequence to CircleCI (dropping pre-embuilder core3.test_hello_world). - Quiet tar archive/extract commands (-czf/-xzf) and remove debug ls output. - Revert unused result.test_duration assignment in test/parallel_testsuite.py.
- test-windows.yml: Use $env:EMSDK_PYTHON (exported by setup-emsdk) for pip install, bootstrap.py, and check_clean.py so test dependencies like xmlrunner are installed into the Python environment used by test/runner.exe, matching CircleCI's pip-install step. - build-and-test-linux.yml (test-other): Install the wasm32-unknown-emscripten Rust target and wasm-bindgen 0.2.128 CLI, and install ccache alongside scons, matching CircleCI's test-misc job. - prepare-for-tests/action.yml: Add $(dirname "$EMSDK_NODE") to GITHUB_PATH so tools invoking 'node' from PATH (such as meson's wasm64-emscripten.ini exe_wrapper) use emsdk's Node v24 rather than the runner's pre-installed Node v22. - install-firefox/action.yml: Preseed and install ttf-mscorefonts-installer so browser.test_sdl_ttf_render_text_solid renders with Microsoft Arial as expected by its reference image.
Some host environments (such as GitHub-hosted ubuntu-latest VMs) return multiple 127.0.0.1 entries when resolving 'localhost' via node:dns / getaddrinfo. Relax the 'localhost' IPv4 address count check from == 1 to >= 1 while keeping the exact == 1 check for numeric address lookups.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.