Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the default minimum browser versions targeted by Emscripten: Chrome (85 to 93), Firefox (79 to 92), and Safari (15.0 to 15.4). These updates are applied to the default settings, documentation, changelog, and test code size expectations. I have no feedback to provide as there are no review comments to assess.
sbc100
force-pushed
the
default_browser_versions
branch
from
November 2, 2026 21:57
53acccf to
63bd576
Compare
Bump the default target browser versions in `src/settings.js`: - `MIN_CHROME_VERSION`: 85 -> 93 - `MIN_FIREFOX_VERSION`: 79 -> 92 - `MIN_SAFARI_VERSION`: 150000 -> 150400 This allows `$hasOwn` in `libcore.js` (introduced in emscripten-core#28129) to use the `Object.hasOwn` fast path by default. See: emscripten-core#28125
sbc100
force-pushed
the
default_browser_versions
branch
from
November 2, 2026 22:55
63bd576 to
947aa42
Compare
kripken
reviewed
Nov 3, 2026
| - The default minimum browser versions targeted by Emscripten were increased: | ||
| - `MIN_CHROME_VERSION`: 85 -> 93 | ||
| - `MIN_FIREFOX_VERSION`: 79 -> 92 | ||
| - `MIN_SAFARI_VERSION`: 15.0 -> 15.4 |
Member
There was a problem hiding this comment.
Maybe add the dates here? That would quickly show people that these defaults are still 4+ years in the past.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the default target browser versions in
src/settings.js:MIN_CHROME_VERSION: 85 -> 93MIN_FIREFOX_VERSION: 79 -> 92MIN_SAFARI_VERSION: 150000 -> 150400This allows
$hasOwninlibcore.js(introduced in #28129) to use theObject.hasOwnfast path by default.Note: This does not effect the minimum browsers versions that we support or the behaviour
-sLEGACY_VM_SUPPORT.See: #28125