[CI] Install browsers using puppeteer/browsers tool. NFC#27113
Merged
Conversation
sbc100
changed the title
sbc100
requested review from
brendandahl and
kripken
and removed request for
kripken
sbc100
force-pushed
the
chrome_for_testing
branch
4 times, most recently
from
9098872 to
84fee0c
Compare
sbc100
changed the title
sbc100
changed the title
sbc100
force-pushed
the
chrome_for_testing
branch
4 times, most recently
from
944560d to
41b623c
Compare
Collaborator
Author
|
@dschuff this makes browser installs so easy, I wonder if we should add them to emscripten-releases waterfall? |
kripken
approved these changes
Jun 12, 2026
sbc100
force-pushed
the
chrome_for_testing
branch
3 times, most recently
from
9c41e93 to
f36fd4d
Compare
sbc100
force-pushed
the
chrome_for_testing
branch
from
f36fd4d to
1dba5d1
Compare
Collaborator
Author
|
@mathiasbynens I know we are very late the game here, but thanks for making the very convenient tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the windows firefox installation a lot and means we can completely delete
run-tests-firefox-windows.This also means we are using chrome-for-testing.
See https://developer.chrome.com/blog/chrome-for-testing