Conversation
emilk
added
the
include in changelog
|
View snapshot changes at kitdiff |
1 task
emilk
added a commit
that referenced
this pull request
Sep 18, 2026
Replaces the last two `impl Into<Id>` parameters with plain `Id`, matching `Plot::id` and the earlier `impl Into<f32>` cleanup in: * #249 Also documents that the group id must be globally unique, and that the very same id must be passed to each plot you want linked. Both link groups live in a single app-wide store keyed by that id, so a colliding id silently links unrelated plots. * [x] I have followed the instructions in the PR template 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These produce warnings on
nightly, and maybe on future stable versions of the compiler