transaction: preserve the error chain in wrapTransportError - #322
Open
Mliviu79 wants to merge 1 commit into
Open
transaction: preserve the error chain in wrapTransportError#322Mliviu79 wants to merge 1 commit into
Mliviu79 wants to merge 1 commit into
Conversation
wrapTransportError rendered the cause with %s, so only ErrTransactionTransport stayed matchable and the underlying write or dial failure was unreachable through errors.Is and errors.As. The cause is wrapped with %w instead. Matching on ErrTransactionTransport is unchanged. Refs emiago#321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
wrapTransportErrorrendered the cause with%s, so onlyErrTransactionTransportstayed matchable and the underlying write or dial failure was unreachable througherrors.Isanderrors.As.The cause is wrapped with
%winstead. Matching onErrTransactionTransportis unchanged — the added test asserts both.