Collect garbage between the phases of pnpm bench - #21654
Draft
NullVoxPopuli wants to merge 1 commit into
Draft
NullVoxPopuli wants to merge 1 commit into
NullVoxPopuli wants to merge 1 commit into
Conversation
Garbage from one phase (render10000Items, for example) was collected inside a later phase, wherever V8 decided to. A change that allocates more or less moved those collections between phases, so phase times shifted for reasons unrelated to the phase itself. Chrome now runs with --expose-gc, and waitForIdle() calls gc() before the next phase starts, outside the measured marks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JqJMavyH9FWrQWG3PAGzsT
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Garbage from one phase (render10000Items, for example) was collected inside a later phase, wherever V8 decided to. A change that allocates more or less moved those collections between phases, so phase times shifted for reasons unrelated to the phase itself.
Chrome now runs with --expose-gc, and waitForIdle() calls gc() before the next phase starts, outside the measured marks.
Claude-Session: https://claude.ai/code/session_01JqJMavyH9FWrQWG3PAGzsT