Document how the get helper treats keys containing a period - #21651
Open
NullVoxPopuli wants to merge 1 commit into
Open
NullVoxPopuli wants to merge 1 commit into
NullVoxPopuli wants to merge 1 commit into
Conversation
The key passed to `{{get}}` is a path, so `{{get obj "some.key"}}`
reads `obj.some.key`. Document that, and show a plain function as the
way to read a property whose name contains a period. Also fix the
sentence after the dynamic key example, which referred to an example
that no longer exists.
Closes emberjs#21411
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013JirFwqPVyTTFj5zPbonSh
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by NullVoxPopuli · project thread
Before: the
{{get}}docs don't say the key is a path, so{{get obj "some.key"}}returningundefinedfor{ "some.key": 1 }is a surprise.After: the docs show that the key is split on periods and looked up one segment at a time, say plainly that a property whose name contains a period can't be read with
{{get}}, and show a plain function as the way to do it. The sentence after the dynamic key example, which referred to an example that no longer exists, now matches the example above it.How: docs only, in
packages/@ember/helper/index.ts.pnpm lint:docspasses.Closes #21411
🤖 Generated with Claude Code
https://claude.ai/code/session_013JirFwqPVyTTFj5zPbonSh