Repository navigation
Introduced Embroider + Webpack - #1227
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| const config = loadConfigFromMeta('ember-website') as unknown; | ||
|
|
||
| assert( | ||
| 'config is not an object', | ||
| typeof config === 'object' && config !== null, | ||
| ); |
There was a problem hiding this comment.
ember-fastboot seemed to cause this assert to throw an error. I replaced the .ts file with a .d.ts for simplicity.
| titleDidUpdate(pageTitle: string): void { | ||
| this.headData.pageTitle = pageTitle; | ||
| } |
There was a problem hiding this comment.
Contrary to the documentation's claim, the titleDidUpdate hook no longer seemed to get called in Embroider + Webpack. I patched the page-title service instead.
| 'ember-cli-mirage': { | ||
| enabled: false, | ||
| }, |
77a77a0 to
b61054b
Compare
| "ember-qunit": "^9.1.0", | ||
| "ember-resolver": "^13.2.0", | ||
| "ember-responsive-image": "^4.0.0", | ||
| "ember-source": "~6.8.0", |
There was a problem hiding this comment.
While ember-responsive-image provides @responsive-image/ember and @responsive-image/webpack, it had made a couple of breaking changes.
- The configuration option's type has changed. Not all options may still be supported.
- The
<ResponsiveImage>no longer accepts a string for@src. (We may need to dynamically import images.)
Since the addon was only used in two places (to show mascots and team members), I decided to remove the addon to reduce scope and the number of files that would need to be reviewed.
We can re-introduce responsive-image later if it's really needed.
b61054b to
b0ec590
Compare
| ? TransformStream | ||
| : require('node:stream/web').TransformStream, | ||
| Headers: typeof Headers !== 'undefined' ? Headers : undefined, | ||
| structuredClone, |
There was a problem hiding this comment.
ember-data@5.8.2 depends on structuredClone.
…vice didn't work with Embroider + Webpack
b0ec590 to
bd3d682
Compare
1 participant
Background
Completes the series of maintenance work since #1215.
What changed?
ember-page-titleto reduce scope.ember-responsive-imageto reduce scope.ember-sourcefrom 6.8.4 to 6.12.0.ember-datafrom 5.7.0 to 5.8.2.