Repository navigation
Removed unnecessary dependencies (Part 3) - #1226
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a520ecf to
4c89d2c
Compare
4c89d2c to
8af2008
Compare
| constructor() { | ||
| // @ts-expect-error: Incorrect type | ||
| // eslint-disable-next-line prefer-rest-params | ||
| super(...arguments); | ||
|
|
||
| void this.fetchCanaryInfo(); | ||
| } |
There was a problem hiding this comment.
For simplicity, I assumed the ideal case (no runtime errors, no retries needed).
8af2008 to
4f0c114
Compare
| ember: this.store.findRecord<Project>('project', 'ember/beta'), | ||
| emberData: this.store.findRecord<Project>('project', 'emberData/beta'), | ||
| }); | ||
| const releases = this.modelFor('releases') as ModelFrom<ReleasesRoute>; |
There was a problem hiding this comment.
The parent route loads all project records, so we could have used peekRecord instead of findRecord. Here, I went with modelFor to remove the dependency on ember-data.
| "paths": { | ||
| "ember-website/tests/*": ["./tests/*"], | ||
| "ember-website/*": ["./app/*"], | ||
| "fetch": ["./node_modules/ember-fetch"], |
There was a problem hiding this comment.
Ember fetch should be fully removed
There was a problem hiding this comment.
Yep, I forgot to previously. The latest commit shows that it has been removed.
| "algoliasearch", | ||
| "crypto" | ||
| "crypto", | ||
| "node-fetch" |
There was a problem hiding this comment.
Built in fetch should work
There was a problem hiding this comment.
Ah, thanks. I copied the configuration from an older commit of ember-api-docs. Will remove it.
4f0c114 to
d8173d1
Compare
2 participants
Background
Removed dependencies so that we can reduce maintenance cost and introduce Embroider more easily.
What changed?
fetchtoapp/templates/releases/canary.gts.ember-fetch(v1 addon).rsvp.How to test
Visit https://deploy-preview-1226--ember-website.netlify.app/releases/canary/, the only place where we used
fetch. Under the section "How to Install > Ember," a hash should appear afterhttps://s3.amazonaws.com/builds.emberjs.com/canary/shas/.