Repository navigation
Update the default sandbox - #956
Merged
mansona merged 4 commits intoSep 10, 2026
Merged
Conversation
Contributor
Author
|
Lints are failing, but also, the project isn't set up for tooling to support node 16... so... 🤷 |
mansona
force-pushed
the
nvp/update-default-sandbox
branch
from
September 10, 2026 22:38
c91f70e to
c966eeb
Compare
mansona
approved these changes
Sep 10, 2026
Member
|
turns out that 3 of the new globals you added (document, MutationObserver, and ResizeObserver) are not available to us in node (because they just don't make any sense) I removed Navigator too because that was added in a very very limited capacity in Node 21 and a) we still support Node 20 for now and b) we should discuss if we want to add this because of its limitations in a separate PR 👍 |
Closed
Merged
Contributor
Author
|
more reason fastboot's whole current approach is bad. It's perfectly reasonable for these things to exist at app boot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People run in to this stuff missing all the time.
We should provide this stuff out of the box.