Skip to content

Implemented a CI workflow in GH actions, updated security.md to inclu…#3

Merged
elyas-code merged 1 commit into
mainfrom
dev
Mar 6, 2026
Merged

Implemented a CI workflow in GH actions, updated security.md to inclu…#3
elyas-code merged 1 commit into
mainfrom
dev

Conversation

@elyas-code

Copy link
Copy Markdown
Owner

…de PGP key for emails. Tests now can run on actions

…de PGP key for emails. Tests now can run on actions
@elyas-code elyas-code self-assigned this Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 14:05
@elyas-code elyas-code merged commit 16e0d44 into main Mar 6, 2026
2 of 8 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub Actions CI so the Rust workspace builds/lints/tests in automation, and updates the project’s security policy (including adding a PGP public key for vulnerability reports).

Changes:

  • Introduce a GitHub Actions workflow running build/test (stable + nightly) plus clippy/fmt (stable).
  • Update SECURITY.md roadmap/status and add an armored PGP public key block.
  • Adjust test fixtures (URL strings) and stop ignoring .github/ in .gitignore.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
engine/tests/feature_support_tests.rs Updates URL-related test fixtures used for parsing/resolution/caching checks.
SECURITY.md Updates roadmap/status terminology and adds a PGP public key for security contact.
.gitignore Allows committing .github/ (needed for workflows).
.github/workflows/ci.yml Adds CI workflow for build/test/clippy/fmt across Linux + Windows (and nightly on Linux).
Comments suppressed due to low confidence (1)

engine/tests/feature_support_tests.rs:51

  • test_resolve_relative_parent_directory has an incorrect expected URL. Given base path /rust-lang/rust/docs/guide.html and relative ../images/logo.png, resolving should drop only docs/ and produce /rust-lang/rust/images/logo.png, not /rust-lang/images/logo.png (that would require ../../images/...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/ci.yml
Comment on lines +20 to +21
- uses: actions/checkout@v3

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v3 is on an older major version (Node16-era) and is deprecated in many repos; consider upgrading to actions/checkout@v4 to avoid future runner deprecations and get current security fixes.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
- uses: actions/checkout@v3

- name: Install Rust
uses: dtolnay/rust-toolchain@master

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using dtolnay/rust-toolchain@master makes the workflow non-reproducible and increases supply-chain risk because the action code can change without review. Pin the action to a tagged release (if available) or a specific commit SHA, while still selecting the toolchain via toolchain: ${{ matrix.rust }}.

Suggested change
uses: dtolnay/rust-toolchain@master
uses: dtolnay/rust-toolchain@v1

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
Comment on lines +27 to +29
- name: Cache cargo registry
uses: actions/cache@v3
with:

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/cache@v3 is an older major version; upgrading to actions/cache@v4 is recommended for current fixes/features and to reduce the chance of future GitHub runner deprecation issues.

Copilot uses AI. Check for mistakes.
Comment thread SECURITY.md
Comment on lines +131 to 135
### Phase 1 (Prealpha - Current)
- Focus: Core engine stability and correctness
- Security: Basic input validation, memory safety
- Internal testing only
- Target: Q1 2026

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document now describes the project as "Prealpha" in the roadmap/status, but earlier sections still say "Alpha" (e.g., intro + "Current Status"). Please make the terminology consistent throughout the file so readers don’t get mixed signals about maturity/support expectations.

Copilot uses AI. Check for mistakes.
Comment thread SECURITY.md
Comment on lines +204 to +210
- PGP Key:

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsDNBGmq3SABDADDt2htuAAYt4GspbMRDLQO5+lfZEvc5Yiq/9z2Aof5j+9LiTEs
uqCV4G6PjAo8ZbLAudp8yJKzRMNKrMtK5P4SBklN4Cgnx3mFw5FjwBh4T5FicGPK
0tofIQNcPMbtwnuIJQLj7DaVUkxhpgEW9K0pcHUAkAGQwvw1KYMJRF/76+XjqZ4z

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PGP public key block should be wrapped in a fenced code block (e.g., text ... ) so Markdown renders it correctly and users can copy/paste it without line-wrapping or formatting artifacts.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants