Skip to content

feat: add RedirectUriPrefix support to OpenIdConnectConfiguration for sub-path deployments - #809

Open
IbrahimNadaa wants to merge 12 commits into
elsa-workflows:mainfrom
IbrahimNadaa:feat-adding-RedirectUriPrefix
Open

feat: add RedirectUriPrefix support to OpenIdConnectConfiguration for sub-path deployments#809
IbrahimNadaa wants to merge 12 commits into
elsa-workflows:mainfrom
IbrahimNadaa:feat-adding-RedirectUriPrefix

Conversation

@IbrahimNadaa

@IbrahimNadaa IbrahimNadaa commented May 8, 2026

Copy link
Copy Markdown

Purpose

Allow applications using the ElsaLogin OIDC flow to configure a path prefix for the redirect_uri,
enabling correct authentication in sub-path deployments where the IdP enforces a specific redirect_uri format.

Scope

Select one primary concern:

  • Bug fix (behavior change)
  • Refactor (no behavior change)
  • Documentation update
  • Formatting / code cleanup
  • Dependency / build update
  • New feature

If this PR includes multiple unrelated concerns, please split it before requesting review.


This produces https://myapp.com/workflow/signin-oidc instead of https://myapp.com/signin-oidc.
When not set, behaviour is unchanged — defaults to {origin}/signin-oidc.


Verification

Steps:

  1. Deploy or configure the Elsa Studio host behind a reverse proxy or sub-path (e.g., /workflow).
  2. Set Authentication:ElsaLogin:RedirectUriPrefix to /workflow in appsettings.json.
  3. Register https://myapp.com/workflow/signin-oidc as an allowed redirect URI in your IdP
    (e.g., Azure AD, Keycloak).
  4. Navigate to Elsa Studio and trigger the OIDC login flow.

Expected outcome: The authorization request is sent with
redirect_uri=https://myapp.com/workflow/signin-oidc, the IdP accepts it, and the user is
successfully authenticated.


Screenshots / Recordings (if applicable)

N/A — No UI changes. This is a configuration and service-layer change only.


Checklist

  • The PR is focused on a single concern
  • Commit messages follow the recommended convention
  • Tests added or updated (if applicable)
  • Documentation updated (if applicable)
  • No unrelated cleanup included
  • All tests pass

@greptile-apps

greptile-apps Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a RedirectUriPrefix property to OpenIdConnectConfiguration so that Elsa Studio OIDC flows work correctly behind a reverse proxy or sub-path deployment (e.g., /workflow). A new StringExtensions helper normalises the prefix and both RedirectToAuthorizationServer and ReceiveAuthorizationCode are updated consistently.

  • RedirectUriPrefix is optional and null-safe; when unset the existing {origin}/signin-oidc behaviour is preserved.
  • An unrelated encoding regression was introduced while stripping the BOM: the HORIZONTAL ELLIPSIS \u2026 (U+2026) on line 136 of OpenIdConnectAuthorizationService.cs was corrupted to the Unicode Replacement Character (U+FFFD), which will garble truncated error log entries.
  • EnsureEndsWith in StringExtensions.cs is defined but never called.

Confidence Score: 4/5

Safe to merge after fixing the corrupted ellipsis character in the error-logging path; the OIDC feature itself is correctly implemented.

The redirect URI construction change is correct and backward-compatible. The one concrete defect is an unintended character corruption on line 136 of OpenIdConnectAuthorizationService.cs — the ellipsis was replaced with the Unicode Replacement Character when the BOM was stripped, meaning every truncated OIDC error log entry will end with a garbled glyph.

src/modules/Elsa.Studio.Login/Services/OpenIdConnectAuthorizationService.cs — specifically line 136 where the ellipsis character was corrupted.

Important Files Changed

Filename Overview
src/modules/Elsa.Studio.Login/Services/OpenIdConnectAuthorizationService.cs Adds RedirectUriPrefix support to redirect URI construction; inadvertently corrupts the ellipsis character (U+2026 to U+FFFD) in ReadErrorSummaryAsync line 136 due to BOM removal.
src/modules/Elsa.Studio.Login/Extensions/StringExtensions.cs New helper file adding EnsureStartsWith and EnsureEndsWith string extensions; EnsureEndsWith is currently unused dead code.
src/modules/Elsa.Studio.Login/Models/OpenIdConnectConfiguration.cs Adds nullable RedirectUriPrefix property with clear XML doc comment; no issues.

Sequence Diagram

sequenceDiagram
    participant Browser
    participant ElsaStudio as Elsa Studio (Blazor)
    participant Config as OpenIdConnectConfiguration
    participant IdP as Identity Provider

    Browser->>ElsaStudio: Navigate to protected route
    ElsaStudio->>Config: Read RedirectUriPrefix (e.g. "/workflow")
    ElsaStudio->>ElsaStudio: "Build redirectUri = origin + EnsureStartsWith + /signin-oidc"
    Note over ElsaStudio: e.g. https://myapp.com/workflow/signin-oidc
    ElsaStudio->>IdP: GET /authorize with redirect_uri
    IdP-->>Browser: 302 to redirect_uri with auth code
    Browser->>ElsaStudio: "GET /workflow/signin-oidc?code=AUTH_CODE"
    ElsaStudio->>Config: Read RedirectUriPrefix again
    ElsaStudio->>ElsaStudio: Rebuild same redirectUri for token exchange
    ElsaStudio->>IdP: POST /token with code and redirect_uri
    IdP-->>ElsaStudio: access_token, refresh_token, id_token
    ElsaStudio-->>Browser: NavigateTo returnUrl
Loading
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
src/modules/Elsa.Studio.Login/Extensions/StringExtensions.cs:19-28
`EnsureEndsWith` is defined but never called anywhere in this PR or the existing codebase. Shipping unused internal code creates unnecessary maintenance surface. If it's genuinely needed in a follow-up, it can be added then; otherwise it should be removed.

### Issue 2 of 2
src/modules/Elsa.Studio.Login/Services/OpenIdConnectAuthorizationService.cs:136
**Corrupted ellipsis character**

The original file (which had a UTF-8 BOM) contained the HORIZONTAL ELLIPSIS `` (U+2026) on this line. When the BOM was stripped in this PR, the multi-byte sequence for that character was corrupted to U+FFFD (the Unicode Replacement Character). At runtime, truncated error summaries logged by `ReadErrorSummaryAsync` will end with the replacement character `<?>` instead of ``, producing garbled log output. Replace the character literal on this line with the correct `` (U+2026), or use the escape `\u2026`.

Reviews (2): Last reviewed commit: "Merge branch 'main' into feat-adding-Red..." | Re-trigger Greptile

Comment thread src/modules/Elsa.Studio.Login/Services/OpenIdConnectAuthorizationService.cs Outdated
Comment thread src/modules/Elsa.Studio.Login/Models/OpenIdConnectConfiguration.cs
@IbrahimNadaa

Copy link
Copy Markdown
Author

@sfmskywalker
please take a look at this PR

@sfmskywalker

Copy link
Copy Markdown
Member

@greptile please review

summary = summary[..MaxLoggedErrorLength];

return truncated ? $"{summary}" : summary;
return truncated ? $"{summary}" : summary;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Corrupted ellipsis character

The original file (which had a UTF-8 BOM) contained the HORIZONTAL ELLIPSIS (U+2026) on this line. When the BOM was stripped in this PR, the multi-byte sequence for that character was corrupted to U+FFFD (the Unicode Replacement Character). At runtime, truncated error summaries logged by ReadErrorSummaryAsync will end with the replacement character <?> instead of , producing garbled log output. Replace the character literal on this line with the correct (U+2026), or use the escape \u2026.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/modules/Elsa.Studio.Login/Services/OpenIdConnectAuthorizationService.cs
Line: 136

Comment:
**Corrupted ellipsis character**

The original file (which had a UTF-8 BOM) contained the HORIZONTAL ELLIPSIS `` (U+2026) on this line. When the BOM was stripped in this PR, the multi-byte sequence for that character was corrupted to U+FFFD (the Unicode Replacement Character). At runtime, truncated error summaries logged by `ReadErrorSummaryAsync` will end with the replacement character `<?>` instead of ``, producing garbled log output. Replace the character literal on this line with the correct `` (U+2026), or use the escape `\u2026`.

How can I resolve this? If you propose a fix, please make it concise.

@greptile-apps

greptile-apps Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@IbrahimNadaa

Copy link
Copy Markdown
Author

appreciate the wonderful package, any update on this we really need this feature

@IbrahimNadaa

Copy link
Copy Markdown
Author

any updates on this?

@dotnet-policy-service

Copy link
Copy Markdown

@IbrahimNadaa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants