Repository navigation
fix(bridge): accept null project values in umbrella handshakes - #8
Merged
Merged
Conversation
Collaborator
|
Great finds, thank you for the fixes and regression tests! All three merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Umbrella roots can omit the
:appentry inmix.exs, as shown in the official Elixir guide. For these projects,Pi.Bridge.Inforeturnsnilfor the project application, which becomesproject: nullin the JSONreadymessage.The extension only accepts
projectas a string or an omitted field. It rejects this valid handshake, leaving the embedded bridge stuck in thestartingstate.Changes
BridgeInfo.projectto be a string,null, or omitted in both the TypeScript type and the runtime schema.project: nullwhile continuing to reject invalid values such as numbers.project: nullin the ready handshake, and runs an AST search.