Repository navigation
fix(ast): preserve local helper matches under broad imports - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pi.AST.search/2can miss local helper calls in modules that use broad imports, such asimport Ecto.Changeset.With ExAST 0.12.0, a local call to
ensure_vector_store_mapping/5is incorrectly resolved asEcto.Changeset.ensure_vector_store_mapping/5. Searching for the local helper therefore returns no matches, even though it is defined and called in the source.Changes
~> 0.12.10, which fixes this import resolution behavior.import Ecto.Changesetand a local helper, asserting that AST search finds both the call and the definition.