fix(nx): keep a reshaped float constant a constant - #1837
Merged
Merged
Conversation
Nx.Defn.Expr.broadcast/4 folds a constant it is given; reshape/2 did not,
so a literal reaching an op through a reshape arrived as a plain node and
missed the constant promotion. Vectorized operands take that route:
defn pick(pred, t), do: Nx.select(pred, 0.1, t)
pick(Nx.vectorize(pred, :a), Nx.vectorize(t_f64, :a))
answered 0.10000000149011612 instead of 0.1.
Folding it drops the reshape and broadcast nodes that wrapped the literal,
so two tests asserting inspected expressions were updated to the smaller
graphs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Eu3cbRr9M6j5qj4Ps4Hgcg
cash-mckeeman
changed the title
polvalente
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broadcast/4folds a constant it's handed;reshape/2didn't, so a literal reaching an op through a reshape arrived as a plain node.Vectorized operands take that route. Folding also drops the reshape and broadcast nodes wrapping the literal, so two tests asserting inspected expressions now assert smaller graphs.
Split out of #1835.
🤖 Generated with Claude Code