Repository navigation
Add spec_lint and warnings-as-errors CI gates - #1
Merged
Merged
Conversation
lukaszsamson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
spec_lintjob (Elixir 1.20.4 / OTP 29, errors only) runningmix spec_lint.The dep is declared only when
Version.match?(System.version(), ">= 1.18.0"), so the Elixir 1.14-1.17 test matrix jobs are unaffected (spec_lint requires Elixir ~> 1.18).Local run: 244 spec clauses checked, 0 errors, 0 warnings. No fixes or ignores needed.
Also: minimum raised to Elixir 1.16 / OTP 26 (1.14/1.15 matrix entries dropped, Dialyzer job moved to 1.16),
mix compile --warnings-as-errorsadded to the spec_lint job (1.20.4/OTP 29), with the^lengthpin fix inGenDAP.Communication.TCP.read_body/3. Existing Dialyzer job passes locally on 1.20.4/OTP 29.Also: removed the commitlint workflow (lint-commit.yaml).