Fix locator for function defined by macro ending with ? or ! - #344
Open
katafrakt wants to merge 1 commit into
Open
Fix locator for function defined by macro ending with ? or !#344katafrakt wants to merge 1 commit into
katafrakt wants to merge 1 commit into
Conversation
Contributor
Author
|
Looks like there are some unrelated CI failures in newest 1.20 line 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex added in #330/#333 does not catch functions ending with
?or!as\bstops at the word boundary. This changes it to use negative lookahead to also consume the ending character for these functions.Issue found via Expert.