Banners show the release version via git describe - #10
Merged
Conversation
elirancv
added a commit
that referenced
this pull request
Jul 7, 2026
elirancv
force-pushed
the
fix/banner-and-unblock-docs
branch
from
July 7, 2026 05:40
716d781 to
73553c3
Compare
Instead of removing versions outright, derive them: banners display the latest git tag (e.g. v5.2.0, or v5.2.0-3-gabc123 when ahead of the tag) resolved at runtime, and stay silent for ZIP copies without .git. One source of truth - the tag - so banners can never drift again the way the hardcoded 4.3 / 4.3.3 / 4.4.0 / 1.0 set did. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
git describe exits 128 in tagless/shallow checkouts (and ZIP copies); the try/catch handles the error but the exit code leaked - CI's powershell wrapper ends with `exit $LASTEXITCODE`, failing the step even though the script succeeded. Caught by the Windows 5.1 CI job. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9 (the commit raced the merge): instead of versionless banners, every script (stage0/1/2/3 + wsl-tools) resolves the latest git tag at runtime and shows it —
v5.2.0at a release tag,v5.2.0-N-gshawhen ahead (honest dev-build style), silent for ZIP copies without .git. One source of truth (the tag), zero per-release maintenance, can never drift like the old 4.3 / 4.3.3 / 4.4.0 / 1.0 set. AGENTS.md invariant updated to match.🤖 Generated with Claude Code