Update to testthat 3#201
Open
olivroy wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Hi @eliocamp ! Let me know what you think or if you need more explanation / PR split |
Owner
|
Hi! Yes, it is a pretty large PR that does a lot of different stuff. It would be great if you could split it into more atomic PRs. |
(I know the diff is bad from GitHub, but I verified that they matched when I first opened the PR.
olivroy
changed the title
Contributor
Author
|
I modified this PR to be only testthat 3. Opened another one for partial matching. I will see if I re-implement the other changes. The move to testthat 3 may help with future proofing the package |
Owner
|
I'm not versed in snapshot testing. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes unused suggests
add a search bar to website also
The added imports don't change anything to the package, since they are already imported by ggplot2.
I wanted to see if I could remove the
{plyr}dependency, but I couldn't. The PR is already big as it is.