Internal: Unskip test welcome test [TMZ-1042]#666
Open
hein-obox wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Re-enabling the "Welcome to Hello Theme" admin test (TMZ-1042) which was previously skipped due to Elementor plugin disabling the banner. Test infrastructure updated to skip only the unrelated Quick Links test that still fails.
2. What Changed (Where)
hello-theme-admin-home.test.ts: Removedtest.skip()wrapper and comment from Welcome message test, converting it back to active testGREP_INVERT_FLAGto skip only Quick Links test (removed Welcome test from exclusion list)3. How It Works
The Welcome banner test now runs again in CI. Grep invert flag remains to exclude the Quick Links test which has persistent failures—creating asymmetry between the two workflows where Welcome is re-enabled but Quick Links continues skipped via CLI invocation rather than
test.skip().4. Risks
Test may fail if Elementor plugin still disables the banner or if the "Go Pro, Go Limitless" locator changed. Inconsistency between workflows (one skips at test definition, other at CLI) could cause maintenance confusion.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how