Internal: Skip pro banner test inside Hello Theme [TMZ-1042]#663
Merged
Conversation
max-zu
approved these changes
Jun 8, 2026
hein-obox
pushed a commit
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
The pro banner test in Hello Theme admin is disabled at the plugin level, making the test fail. Skipping it prevents CI breakage while maintaining the test suite.
2. What Changed (Where)
hello-theme-admin-home.test.ts: Addedtest.skip()wrapper and explanatory comment to the "Welcome to Hello Theme" screenshot test (lines 9-10).3. How It Works
The test declaration now uses Playwright's
test.skip()method, which prevents execution while keeping the test visible in reports for future reference.4. Risks
None — this is a defensive measure for an already-failing test that blocks CI. The skip is temporary and documented.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how