Skip to content

Don't skip draft PR comment job for manual workflow trigger - #894

Merged
lewisgoddard merged 3 commits into
mainfrom
vishal/dont-skip-manual-workflow-comment-job-for-draft-PRs
Sep 27, 2026
Merged

lewisgoddard merged 3 commits into
mainfrom
vishal/dont-skip-manual-workflow-comment-job-for-draft-PRs

Conversation

@vjr

@vjr vjr commented Sep 27, 2026

Copy link
Copy Markdown
Member

Also find draft PR number for a manual workflow_dispatch when the pull_request event is not available.

Also find draft PR number for a manual workflow_dispatch when the pull_request event is not available.
@vjr
vjr requested a review from lewisgoddard September 27, 2026 07:46
@vjr vjr self-assigned this Sep 27, 2026
@vjr
vjr marked this pull request as draft September 27, 2026 07:47
@vjr
vjr marked this pull request as ready for review September 27, 2026 07:47
@vjr

vjr commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

Hit this issue (skipped comment step) when working on draft PR #873 but don't know how to test before merging, hopefully the change is ok?

@github-actions

Copy link
Copy Markdown

Installer builds for b8c1b1a

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260927075235.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260927074929.iso sha256

@vjr
vjr marked this pull request as draft September 27, 2026 08:37
@github-actions

Copy link
Copy Markdown

Installer builds for b8c1b1a

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260927084148.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260927084016.iso sha256

@vjr
vjr marked this pull request as ready for review September 27, 2026 09:12
@vjr

vjr commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

wooo @lewisgoddard looks like the workflow (commenting) succeeds for both ready and draft PRs as evidenced by the comments in this PR itself, the second one was run when in draft state and all comments' links are good.

@github-actions

Copy link
Copy Markdown

Installer builds for b8c1b1a

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260927091523.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260927091347.iso sha256

@lewisgoddard
lewisgoddard merged commit 12340a2 into main Sep 27, 2026
2 checks passed
@lewisgoddard
lewisgoddard deleted the vishal/dont-skip-manual-workflow-comment-job-for-draft-PRs branch September 27, 2026 15:33
@github-actions

Copy link
Copy Markdown

Installer builds for 38060f8

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260927153525.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260927153451.iso sha256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants