Skip to content

Set ISO label name instead of default ISOIMAGE - #888

Merged
lewisgoddard merged 8 commits into
mainfrom
vishal/label-iso
Sep 27, 2026
Merged

lewisgoddard merged 8 commits into
mainfrom
vishal/label-iso

Conversation

@vjr

@vjr vjr commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Set ISO label to elementary OS 26.09 x86-64 a.k.a "elementary OS ${DATE:0:5} ${ARCH}".

EDIT:

The final choice (for this PR at least) is in aafeacb to set the label like elementary OS stable x86-64 a.k.a. "elementary OS ${PROFILE} ${ARCH}" which fits in the 32-char limit for all current arch and profile options.

I'm unsure whether the mkrescue/xorriso will warn or fail if the limit is breached later on (in case there are new longer profile/arch values) but that's a one-liner fix that can be added later if something breaks.

@vjr vjr self-assigned this Sep 26, 2026
@vjr
vjr requested review from danirabbit and jumpyvi September 26, 2026 03:19
@jumpyvi

jumpyvi commented Sep 26, 2026

Copy link
Copy Markdown
Member

Not really sure about this...

Daily means its own thing, not necessarily early access.

The iso name is also already quite long too imo.

@danirabbit since you are working on the new release format, do you think this could help?

@vjr

vjr commented Sep 26, 2026

Copy link
Copy Markdown
Member Author

Not really sure about this...

Daily means its own thing, not necessarily early access.

The iso name is also already quite long too imo.

@danirabbit since you are working on the new release format, do you think this could help?

I could set to just "elementary OS" always? Currently the ISO results in the usb stick showing "ISOIMAGE" (or was it "MKIMAGE" something like that) which looks like some default label.

@lewisgoddard

lewisgoddard commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

We do make daily branch available on builds.elementary.io as "elementary OS Early Access".

If we have 32 characters maybe the version too: "elementary OS daily 26.09+231233" fits exactly.

Stable cutting off at + doesn't seem to bad, as they likely won't be built as often.

@vjr

vjr commented Sep 26, 2026 •

Copy link
Copy Markdown
Member Author

We do make daily branch available on builds.elementary.io as "elementary OS Early Access".

If we have 32 characters maybe the version too: "elementary OS daily 26.09+231233" fits exactly.

Stable cutting off at + doesn't seem to bad, as they likely won't be built as often.

So we no longer want to use the wording "Early Access" ? That makes this PR simpler, I can just label it "elementary OS $PROFILE" so it looks like "elementary OS daily" (or "stable" or "proposed") etc...

Do we want to include just the YY.MM portion too?

@lewisgoddard

Copy link
Copy Markdown
Member

I do feel like knowing the version without needing to boot it is quite useful.

@github-actions

Copy link
Copy Markdown

Installer builds for 62e928a

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260926032054.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260926032025.iso sha256

@vjr

vjr commented Sep 26, 2026

Copy link
Copy Markdown
Member Author

How about keep it simple? Label it "elementary OS YY.MM ARCH" without the $PROFILE in b8254b6 - this is only the label visible on the usb stick, no changes to the filename or other areas - should be fine, right?

@vjr
vjr marked this pull request as draft September 26, 2026 04:41
@vjr
vjr requested a review from lewisgoddard September 26, 2026 04:41
@danirabbit

Copy link
Copy Markdown
Member

Just copying some conversation from discord:

My understanding is this only shows up when you mount the install disk in a file manager for example? So I guess the decision we're making at that time is if this is a disk that needs to be formatted?

If this were showing in the bootloader I would say version and channel is important and arch probably not important

But, since we're always only one update away from latest, version might not be that important in the case of just naming the physical drive itself. But arch and channel seems like it would be important if you're trying to figure out if you want to write over this drive with a new image

An i understanding correctly?

@vjr
vjr marked this pull request as ready for review September 27, 2026 01:43
@vjr

vjr commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

Great, thank you all, will merge this. I'm unsure whether the mkrescue/xorriso will only warn or fail if the limit is breached later on (in case there are new longer profile/arch values added) but that's a one-liner fix that can be added later if the build breaks.

@lewisgoddard
lewisgoddard merged commit 1bd435b into main Sep 27, 2026
4 checks passed
@lewisgoddard
lewisgoddard deleted the vishal/label-iso branch September 27, 2026 02:10
@github-actions

Copy link
Copy Markdown

Installer builds for 5fd7c87

Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.

Arch ISO Checksum
amd64 elementaryos-9.0-proposed-x86-64.20260927014519.iso sha256
arm64 elementaryos-9.0-proposed-arm64.20260927014436.iso sha256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants