Skip to content

Reduced scope port delete/trash operations of Vala - #2844

Open
jeremypw wants to merge 67 commits into
mainfrom
jeremypw/reduced-delete-trash-port
Open

Reduced scope port delete/trash operations of Vala#2844
jeremypw wants to merge 67 commits into
mainfrom
jeremypw/reduced-delete-trash-port

Conversation

@jeremypw

@jeremypw jeremypw commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Do not touch EmptyTrashJob.vala
  • Split out standalone changes

Based on the full port (#2831 ), reverting changes as required.

@jeremypw
Start to move delete files to Vala
4fc1a0b
@jeremypw
Call FileChanges.queue_file_removed for each successful delete
e1d728a
@jeremypw
Report progress during delete
5c79d43
@jeremypw
Start to implement trash files
87952c5
@jeremypw
Merge branch 'main' into jeremypw/fileoperations/delete-files-vala
5f5bbcd
@jeremypw
Disambiguate common job parameter
b46ea50
@jeremypw
Ensure files to retrieve table is not null
72bf376
@jeremypw
Implement trash, use Gee.LinkedList<string> as parameter
fe50af5
@jeremypw
Use Vala delete for drop on trash
368167e
@jeremypw
Merge branch 'main' into jeremypw/fileoperations/delete-files-vala
674a406
@jeremypw
Confirm permanent deletion
9c28898
@jeremypw
Tidy up a little
748fccb
@jeremypw
Abort trash/delete if scan_sources aborts
ca70643
@jeremypw
We do not need to worry about skipped files
f45a19b
@jeremypw
Lose unused skipped_deletion
7dc9cc9
@jeremypw
Missed cleanup
fbca371
@jeremypw
temp commit
61b3736
@jeremypw
Simplify report progress, additional calls
6381717
@jeremypw
Return boolean some_not_deleted
d2b7959
@jeremypw
Prepare to make EmptyTrashJob derive from DeleteJob
6bfbfb0
@jeremypw
Make EmptyTrashJob derive from DeleteJob
b6c8035
@jeremypw
Separate delete_dir_children (); cleanup
992a4c5
@jeremypw
Only public methods async
225fc83
@jeremypw
Fix success logic
d02b63a
@jeremypw
Additional terminal message on failed delete
442d4a0
@jeremypw
Use OperationsManager.delete in Clipboard
6ac64a7
@jeremypw
Prevent marlin_operations_copy_move_link handling trash destination
7287580
@jeremypw
Comments, cleanup
df05f3b
@jeremypw
Revert unnecessary change
dd595c0
@jeremypw
Merge branch 'main' into jeremypw/fileoperations/delete-files-vala
af0ac87
@jeremypw
Reset source and transfer infos when required
64da19f
@jeremypw
Lose unused parameter
ab67627
@jeremypw
Lose unnecessary test in AbstractDirectoryView
1fa7f1a
@jeremypw
DeleteJob: Split out delete_files, clarify and comment
5169b13
@jeremypw
Revert "Lose unnecessary test in AbstractDirectoryView"
1391973 
This reverts commit 1fa7f1a.
@jeremypw
Temp commit
0c44ef4
@jeremypw
Port error handling on getting enumerator in delete_dir_children
0c0414c
@jeremypw
Add some comments
edfac1c
@jeremypw
Merge branch 'main' into jeremypw/fileoperations/delete-files-vala
4e73537
@jeremypw
Use run_warning in delete_file; fail early; comments
bc51cb6
@jeremypw
Comment, whitespace
cb5e03c
@jeremypw
Remove some ported C code
0cf53d2
@jeremypw
Only update transferinfo and FileChanges in delete_file and trash_files
37d6383
@jeremypw
Remove debug code
c822a3d
@jeremypw
Various cleanup
ba3e065
@jeremypw
Reinstate async methods
ae90108
@jeremypw
Fix possible crash in plugin (to split out)
0922f62
@jeremypw
Trash files async, check progress aborted after each file
e92b594
@jeremypw
delete file async
22d2294
@jeremypw
Expand comment, lose unused
7770ea8
@jeremypw
Ensure trash called first and scan_sources has clean infos
f0256d0
@jeremypw
Ensure timer started when needed and report progress at start
f668d97
@jeremypw
Delete more C code
02a3ed2
@jeremypw
Better loop in trash files
6c646c7
@jeremypw
Delete more C code
e5d3a7d
@jeremypw
Revert extraneous whitespace in Directory.vala
76fb268
@jeremypw
Lose extraneous whitespace, warnings, indentation, correct header
0d8cf11
@jeremypw
Cleanup UndoManager and AbstractDirectory changes
22288a1
@jeremypw
remove final comment out C code
16c8460
@jeremypw
Revert EmptyTrashJob.vala to main version
128f2c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeremypw