feat: request review from original author on manual backports - #421
Merged
Conversation
dsanders11
marked this pull request as ready for review
August 18, 2026 23:02
dsanders11
approved these changes
Aug 18, 2026
VerteDinde
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by David Sanders · Slack thread
Before: when a maintainer manually backports a PR on behalf of someone else, the original PR's author is not requested for review on the backport PR — only the default backport review team is tagged.
After: the original PR's author is also requested for review on manual backports, when they have write access to the repo — matching what trop already does for automatic backports.
How:
updateManualBackportalready fetches the original PR when a new manual backport is opened, so its call totagBackportReviewersnow passes the original PR author's login asuser, the same way the automatic backport path does.tagBackportReviewersalready guards oncheckUserHasWriteAccess, so authors without write access are still skipped. Since GitHub rejects requesting a review from a PR's own author, the author is not passed when they opened the manual backport themselves.Generated by Claude Code