fix(cli): detect TTY for interactive mode instead of hardcoding true#4259
fix(cli): detect TTY for interactive mode instead of hardcoding true#4259erickzhao wants to merge 1 commit into
Conversation
…4219) * fix(start): detect TTY for interactive mode instead of hardcoding true * ci: trigger new CI run --------- Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — clean port of #4219 (already merged to main): one-line TTY detection fix plus tests.
Extended reasoning...
Overview
This PR ports #4219 from main to (presumably) a release branch. The substantive change is a single line in packages/api/cli/src/electron-forge-start.ts: interactive: true becomes interactive: process.stdin.isTTY ?? false. A new spec file adds three test cases covering TTY=true, TTY=undefined, and the -- arg-passthrough path.
Security risks
None. The change reads a process property to choose a boolean and does not affect any auth, IO, or untrusted-data paths.
Level of scrutiny
Low. This is a one-line behavior fix in CLI bootstrap code, with the original PR (#4219) already merged on main (commit e7f7700 is visible in the recent commit log). The port carries the same diff plus tests.
Other factors
The added tests directly cover the new behavior. The ?? false fallback is correct since process.stdin.isTTY is true | undefined. No outstanding reviewer comments.
3 participants
Ports #4219 from
main