Add option to select color for ball, paddle, brick - #7
Open
arjunmahishi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a panel below the canvas to pick the colors and potentially other configs. I have not put this in a browser prompt as it may not be the best of ways to do this.
Right now, the colors can be picked during the game, this will be solved when there is a way to play/pause the game (#3 or #2 ).
Also, since we are reloading the page after the game ends, the colors also get reset. This behaviour can be avoided by running the game in a loop instead of only running it at first load. Will create an issue for it.
(addressing #1 )