Add audit and diagnostic commands#209
Conversation
|
Hi, I think these new commands might be useful for us developing and debugging transcrypt as part of the PBKDF2 work, but I don't think they are appropriate to add for general use. I think we could reduce both the diagnose and audit commands to a short warning message or two, that would recommend that users:
These warnings could be shown during transcrypt init, and maybe even every time transcrypt processes files similar to the dreaded Any transcrypt settings or setting combinations that are bad enough to prompt an audit warning should not be permitted in non-legacy repos. |
|
To be clearer, I think we should detect current settings and system capabilities as these two commands are doing, but during init (to start with) not as explicit commands, and only print something like the following as a result: When PBKDF2 is supported but legacy encryption is enabled, print something like this (imagining we have a When PBKDF2 is not supported due to an old version of OpenSSL, print something like: |
With respect to my recent comment: #134 (comment)
This is a simple PR that is meant to help enable the transition to more secure defaults. The diagnose crypto lets the user see what sort of library support their openssl version has:
And for a repo that hasn't been migrated yet, you might get something that looks like this (note this repo does have pbkdf2 enabled via my fork, it just happens to be readable via
current_crypto_setting):