Skip to content

Refine trigger comment regex patterns#3327

Merged
Mpdreamz merged 1 commit intomasterfrom
Mpdreamz-patch-2
May 3, 2026
Merged

Refine trigger comment regex patterns#3327
Mpdreamz merged 1 commit intomasterfrom
Mpdreamz-patch-2

Conversation

@Mpdreamz
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz commented May 3, 2026

Updated regex patterns for trigger comments to enforce start of line matching.

Updated regex patterns for trigger comments to enforce start of line matching.
@Mpdreamz Mpdreamz requested a review from a team as a code owner May 3, 2026 15:20
@Mpdreamz Mpdreamz requested a review from reakaleek May 3, 2026 15:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Mpdreamz
Copy link
Copy Markdown
Member Author

Mpdreamz commented May 3, 2026

run docs-build

@Mpdreamz Mpdreamz merged commit 59dffc8 into master May 3, 2026
4 checks passed
@Mpdreamz Mpdreamz deleted the Mpdreamz-patch-2 branch May 3, 2026 16:00
Mpdreamz added a commit that referenced this pull request May 4, 2026
The docs-build-pr pipeline has a branch filter in Buildkite that only
allows master. All other repos in job 0 use always_trigger_branch:master
so they always build against master and pass the filter. The standalone
elastic/docs job (job 1) has no always_trigger_branch, so the pr-bot
triggers against the PR's feature branch which the pipeline filter
silently rejects.

Previously builds appeared to work because the doc-preview GitHub Actions
workflow posts a comment containing the text "run docs-build", which
accidentally matched the old unanchored trigger_comment_regex. Tightening
the regex with ^ and $ anchors (#3327) inadvertently removed that
accidental trigger.

Setting ignore_pipeline_branch_filters: true tells the Buildkite API to
bypass the pipeline's branch filter, allowing build_on_commit and comment
triggers to work as intended per the buildkite-pr-bot design.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cotti pushed a commit that referenced this pull request May 4, 2026
The docs-build-pr pipeline has a branch filter in Buildkite that only
allows master. All other repos in job 0 use always_trigger_branch:master
so they always build against master and pass the filter. The standalone
elastic/docs job (job 1) has no always_trigger_branch, so the pr-bot
triggers against the PR's feature branch which the pipeline filter
silently rejects.

Previously builds appeared to work because the doc-preview GitHub Actions
workflow posts a comment containing the text "run docs-build", which
accidentally matched the old unanchored trigger_comment_regex. Tightening
the regex with ^ and $ anchors (#3327) inadvertently removed that
accidental trigger.

Setting ignore_pipeline_branch_filters: true tells the Buildkite API to
bypass the pipeline's branch filter, allowing build_on_commit and comment
triggers to work as intended per the buildkite-pr-bot design.

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants